[16.0][IMP] sale_elaboration: set products profile from its categories by Andrii9090-tecnativa · Pull Request #3809 · OCA/sale-workflow

Andrii9090-tecnativa · 2025-07-10T14:34:28Z

I added new functionality to propagate the elaboration profile from the category to the products. When you set the elaboration profile in the category, all its products will have this profile.

MT-10786 @moduon @yajo @rafaelbn @Shide @chienandalu @u0f please review if you want 😄

OCA-git-bot · 2025-07-10T14:34:35Z

Hi @yajo, @rafaelbn, @sergio-teruel, @CarlosRoca13,
some modules you are maintaining are being modified, check this out!

chienandalu

Thanks @Andrii9090 ! Some comments below:

The title of the PR should be: [16.0][IMP] sale_elaboration: add new functionality to propagate the elaboration profile from the category to the product
You can use a more concise title anyway: [16.0][IMP] sale_elaboration: set products profile from its categories
Check tests fails.

sale_elaboration/models/product_elaboration_profile.py

sale_elaboration/models/product_template.py

sale_elaboration/tests/test_sale_elaboration.py

chienandalu · 2025-07-11T08:27:54Z

sale_elaboration/views/product_category_views.xml

+            <xpath expr="//tree" position="attributes">
+                <attribute name="multi_edit">1</attribute>
+            </xpath>


Add a comment on why you're doing this

I have added comment

sale_elaboration/models/product_category.py

chienandalu

Some more small changes ;)

chienandalu · 2025-07-17T15:12:03Z

sale_elaboration/models/product_category.py

+        comodel_name="product.elaboration.profile", string="Elaboration Profile"
+    )
+
+    def write(self, vals):


You should deal with the create as well

chienandalu · 2025-07-17T15:15:36Z

sale_elaboration/readme/CONFIGURE.rst

+#. Go to *Inventory > Configuration > Product Categories* and select one or you 
+can add a column of Elaboration Profiles in the Product Categories list view.
+#. Set the elaboration profile you want to use for all products in this category. 
+It is used in the case if the category hasn't child category. When you 
+create/update a product, the elaboration profile is set from the product's 
+category if the elaboration profile isn't yet setted.


Keep some idention so it's easier to read it in code:

Suggested change

#. Go to *Inventory > Configuration > Product Categories* and select one or you

can add a column of Elaboration Profiles in the Product Categories list view.

#. Set the elaboration profile you want to use for all products in this category.

It is used in the case if the category hasn't child category. When you

create/update a product, the elaboration profile is set from the product's

category if the elaboration profile isn't yet setted.

#. Go to *Inventory > Configuration > Product Categories* and select one or you

can add a column of Elaboration Profiles in the Product Categories list view.

#. Set the elaboration profile you want to use for all products in this category.

It is used in the case if the category hasn't child category. When you

create/update a product, the elaboration profile is set from the product's

category if the elaboration profile isn't yet setted.

chienandalu · 2025-07-17T15:17:36Z

sale_elaboration/readme/CONFIGURE.rst

+#. Go to *Inventory > Configuration > Product Categories* and select one or you 
+can add a column of Elaboration Profiles in the Product Categories list view.


Add that in an extra comment after this block like: You can also use multi-edit in the list view to set the profile in multiple categories at once. Just unhide it from the dots in the right.

Suggested change

#. Go to *Inventory > Configuration > Product Categories* and select one or you

can add a column of Elaboration Profiles in the Product Categories list view.

#. Go to *Inventory > Configuration > Product Categories* and select one.

chienandalu · 2025-07-17T15:20:40Z

sale_elaboration/readme/CONFIGURE.rst

+It is used in the case if the category hasn't child category. When you 
+create/update a product, the elaboration profile is set from the product's 
+category if the elaboration profile isn't yet setted.


Set this aside:

When you create product or update its category , the elaboration profile is set from the product's
category. Anyway, it's possible to change it afterwards.

Suggested change

It is used in the case if the category hasn't child category. When you

create/update a product, the elaboration profile is set from the product's

category if the elaboration profile isn't yet setted.

The profiles is just set in the category products and it won't be propagated to the child category products.

sale_elaboration/models/product_template.py

Andrii9090-tecnativa · 2025-07-31T14:46:59Z

This short video highlights the newest improvements to the module. Thank you @yajo 😄

16.0.IMP.sale_elaboration_.set.products.profile.from.its.categories.3809.mp4

OCA-git-bot · 2025-07-31T14:51:42Z

Hi @sergio-teruel, @CarlosRoca13, @yajo, @rafaelbn,
some modules you are maintaining are being modified, check this out!

chienandalu

I can't see the logic. Maybe you scrambled your commits? 😅

yajo · 2025-08-04T08:26:42Z

sale_elaboration/views/product_views.xml

            </field>
        </field>
    </record>
-


issue: Please disable the automatic formatter that you probably have in your IDE for XML files, and that removes these lines. Then, leave them as they were.

These lines are not wrong. Just let prettier (the one in pre-commit) do the formatting. This way we avoid distractions when reviewing these unneeded stylistic changes.

chienandalu

@Andrii9090 I changed the orientation of your changes for the most simple logic that gets to the original goal.

In a summary

The module behaves as it was until now.
When we set a elaboration profile in the category and no profile is set in the product, that will be the default. Otherwise, no profile is applied and all the elaborations are available.
Sadly, it's hard to test this with the test.Form tools (I'll do some research) as the domain is evaluated in the view and it seems that it doesn't care about it at that level... O left some of your original test case declarations... although the go with no effect, so maybe I remove them for the sake of commit clarity...

@rafaelbn @sergio-teruel all yours if you want to review 🙂

Elaboration profiles can now be set from the category so if no profile is set in the product it defaults to that one. TODO: - `test.Form` doesn't constrain the view domain for profiles... so the only way to test the flow would be either to use a helper domain field or a tour... Some tooling left in the test case anyway. MT-10786 Co-authored-by: David Vidal <david@moduon.team>

rafaelbn

Tested functionaly 👍🏼

2 minutes video with a full explanation

https://www.loom.com/share/d0570c9362ce47e6abd853135aac6807?sid=8ae7d7f6-80f9-4df0-8cc7-85999139cedf

fcvalgar

Functional review,

LGTM, thank you @Andrii9090

rafaelbn · 2025-08-09T07:32:02Z

/ocabot merge minor

OCA-git-bot · 2025-08-09T07:32:11Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3809-by-rafaelbn-bump-minor, awaiting test results.

rafaelbn · 2025-08-09T07:32:43Z

Please @chienandalu port to 17 and 18 in the same task 😄 ❤️ Thank you!

OCA-git-bot · 2025-08-09T07:44:14Z

Congratulations, your PR was merged at 6e0e4af. Thanks a lot for contributing to OCA. ❤️

chienandalu suggested changes Jul 11, 2025

View reviewed changes

Andrii9090-tecnativa changed the title ~~[IMP[16.0]] sale_elaboration: add new functionality to propagate the elaboration profile from the category to the products~~ [16.0][IMP] sale_elaboration: set products profile from its categories Jul 11, 2025

Andrii9090-tecnativa force-pushed the 16.0-IMP-sale_elaboration branch from 1050eed to 774a020 Compare July 11, 2025 15:49

Andrii9090-tecnativa requested a review from chienandalu July 14, 2025 10:13

chienandalu suggested changes Jul 17, 2025

View reviewed changes

Andrii9090-tecnativa force-pushed the 16.0-IMP-sale_elaboration branch from 774a020 to e9c3de5 Compare July 18, 2025 13:53

Andrii9090-tecnativa requested a review from chienandalu July 22, 2025 07:42

Andrii9090-tecnativa marked this pull request as draft July 30, 2025 07:03

Andrii9090-tecnativa force-pushed the 16.0-IMP-sale_elaboration branch from e9c3de5 to 7cf2130 Compare July 31, 2025 13:46

Andrii9090-tecnativa closed this Jul 31, 2025

Andrii9090-tecnativa reopened this Jul 31, 2025

Andrii9090-tecnativa marked this pull request as ready for review August 1, 2025 09:56

chienandalu approved these changes Aug 4, 2025

View reviewed changes

yajo requested changes Aug 4, 2025

View reviewed changes

chienandalu force-pushed the 16.0-IMP-sale_elaboration branch from 7cf2130 to 8ca723b Compare August 7, 2025 08:15

chienandalu reviewed Aug 7, 2025

View reviewed changes

chienandalu force-pushed the 16.0-IMP-sale_elaboration branch from 8ca723b to 0dc1f08 Compare August 7, 2025 08:37

rafaelbn added enhancement needs review labels Aug 7, 2025

rafaelbn added this to the 16.0 milestone Aug 7, 2025

rafaelbn approved these changes Aug 8, 2025

View reviewed changes

rafaelbn requested a review from yajo August 8, 2025 10:02

fcvalgar approved these changes Aug 8, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 9, 2025

OCA-git-bot merged commit 1874c7e into OCA:16.0 Aug 9, 2025
15 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 9, 2025

This was referenced Aug 11, 2025

[18.0][IMP] sale_elaboration: elaboration profile from product category #3857

Merged

[17.0][IMP] sale_elaboration: elaboration profile from product category #3858

Merged

Shide deleted the 16.0-IMP-sale_elaboration branch August 19, 2025 07:52

		#. Go to Inventory > Configuration > Product Categories and select one or you
		can add a column of Elaboration Profiles in the Product Categories list view.

Uh oh!

Conversation

Andrii9090-tecnativa commented Jul 10, 2025

Uh oh!

OCA-git-bot commented Jul 10, 2025

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chienandalu Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Andrii9090-tecnativa Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

chienandalu Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

chienandalu Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

chienandalu Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

chienandalu Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Andrii9090-tecnativa commented Jul 31, 2025

Uh oh!

OCA-git-bot commented Jul 31, 2025

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

yajo Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn left a comment

Choose a reason for hiding this comment

Uh oh!

fcvalgar left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Aug 9, 2025

Uh oh!

OCA-git-bot commented Aug 9, 2025

Uh oh!

rafaelbn commented Aug 9, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Aug 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yajo Aug 4, 2025 •

edited

Loading