[19.0] [MIG] `sale_cancel_reason` by NachoAlesLopez · Pull Request #4105 · OCA/sale-workflow

NachoAlesLopez · 2026-01-14T07:49:13Z

No description provided.

(../trunk-generic/ rev 29.1.1)

(../trunk-generic/ rev 32.1.1)

(../trunk-generic/ rev 32.1.2)

- Update travis.yml to 8.0

Only hide button instead of renaming it

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

… of sale_cancel_reason module

* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/de/

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/zh_CN/

Currently translated at 95.7% (22 of 23 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/es_CL/

Currently translated at 100.0% (18 of 18 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_cancel_reason/sv/

lfreeke

👍 (Functional test)

rousseldenis · 2026-01-20T08:30:57Z

/ocabot migration sale_cancel_reason

rousseldenis · 2026-01-20T08:33:00Z

@@ -16,17 +16,17 @@ class SaleOrder(models.Model):
        copy=False,
    )

-    def _show_cancel_wizard(self):
-        for order in self:
-            if not order._context.get("disable_cancel_warning"):


@NachoAlesLopez You removed this functionality to avoid the wizard ?

It appears that the latest version removed the method and context to show the cancel wizard or cancel the order straight away. I've now re-added the condition in the view based on the same context key from version 18.0.

alexey-pelykh

Thanks for the migration, nice clean work overall.

One thing I noticed: wizard/mass_cancel_orders.py is missing the license header (copyright + AGPL-3 notice) that all the other Python files have. Small fix but worth adding for consistency.

Everything else looks good to me -- the disable_cancel_warning context approach for toggling between the native and custom cancel buttons is clean, security ACLs are properly scoped, the action_draft reset of the cancel reason makes sense, and the tests cover the main flows well (single cancel, mass cancel, and draft reset).

alexey-pelykh · 2026-03-01T15:21:00Z

@@ -0,0 +1,13 @@
+from odoo import fields, models


Missing license header -- all other .py files in this module have the Copyright ... / License AGPL-3.0 or later block. Could you add it here as well?

OCA-git-bot · 2026-03-01T15:26:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

alexey-pelykh

Thanks for squashing -- the migration looks clean.

My earlier note still applies: wizard/mass_cancel_orders.py is the only Python file without the license header (copyright + AGPL-3 notice). Not blocking, but would be nice to add for consistency with the rest of the module.

Otherwise everything is solid: manifest, security, views, tests, and the cancel-button toggling via disable_cancel_warning context all look good for 19.0.

NachoAlesLopez · 2026-03-09T10:28:02Z

+# © 2013 Guewen Baconnier, Camptocamp SA
+# © 2022 Landoo Sistemas de Informacion SL
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).3


@alexey-pelykh

Thanks for squashing -- the migration looks clean.

My earlier note still applies: wizard/mass_cancel_orders.py is the only Python file without the license header (copyright + AGPL-3 notice). Not blocking, but would be nice to add for consistency with the rest of the module.

Otherwise everything is solid: manifest, security, views, tests, and the cancel-button toggling via disable_cancel_warning context all look good for 19.0.

Done! I copied the copyright notice from "wizard/sale_order_cancel_wizard.py". Should be fine like this, right?

BhaveshHeliconia

Functional review LGTM!

Guewen Baconnier and others added 30 commits January 14, 2026 07:59

[MRG] from master branch

3f57efe

(../trunk-generic/ rev 29.1.1)

[FIX] sale cancel reason dependence

ee1706d

(../trunk-generic/ rev 32.1.1)

[FIX] sale_cancel_reason: remove dependency on sale_stock

7bb6f84

(../trunk-generic/ rev 32.1.2)

spellcheck

1f9699f

[FIX] repository PEP8

13f13f6

[FIX] Still some PEP8 erros

6bd9427

- Set as uninstallable and moved to __unported__ dir all modules.

428417e

- Update travis.yml to 8.0

reactivate sale_cancel_reason

4d2affe

port models and method to api 8.0

42872b4

Improve override of cancel button to ease inheritance of view

854e3b0

Only hide button instead of renaming it

[FIX] typo on class name

f9c41c6

Add OCA as author of OCA addons

da72162

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Added Finnish translations

f950d2a

[FIX] cancel button of orignal view should be hide after installation…

c6bf43b

… of sale_cancel_reason module

Add missing default oca icons

090f18b

Slovene translations added

fcd3ea1

bump version of sale_cancel_reason

0b27575

OCA Transbot updated translations from Transifex

95ffb1f

[MIG] Make modules uninstallable

d19a4fb

[FIX] remove en.po that was erroneously created by transbot

e2b8539

[MIG] Rename manifest files

8280eca

[MIG] sale_cancel_reason Migration to 10.0 (OCA#477)

3249d2b

* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2

remove obsolete .pot files [ci skip]

de1ab81

Translated using Weblate (Portuguese)

6f5444d

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/

[MIG] sale_cancel_reason: Migration to 12.0

dd0a353

Translated using Weblate (German)

d583fc1

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/de/

[12.0][FIX] Sale Order Cancel Reasons menu configuration

1f3f4e3

sale_cancel_reason 12.0.1.1.0

65fe910

jakobkrabbe and others added 4 commits January 14, 2026 08:06

Translated using Weblate (Swedish)

178c840

Currently translated at 100.0% (18 of 18 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_cancel_reason/sv/

[IMP] sale_cancel_reason: pre-commit auto fixes

defbde1

[MIG] sale_cancel_reason: Migration to 18.0

33dc969

[IMP] sale_cancel_reason: pre-commit auto fixes

2006788

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch 3 times, most recently from be53939 to b95a32c Compare January 14, 2026 08:04

NachoAlesLopez mentioned this pull request Jan 14, 2026

Migration to version 19.0 #3914

Open

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch from b95a32c to 93733e9 Compare January 14, 2026 08:16

lfreeke approved these changes Jan 16, 2026

View reviewed changes

rousseldenis added needs review migration labels Jan 20, 2026

OCA-git-bot added this to the 19.0 milestone Jan 20, 2026

rousseldenis reviewed Jan 20, 2026

View reviewed changes

rousseldenis added the question label Jan 20, 2026

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch 2 times, most recently from c9a26ad to ca8e716 Compare February 16, 2026 07:04

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch from ca8e716 to 3134141 Compare February 26, 2026 07:02

alexey-pelykh approved these changes Mar 1, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 1, 2026

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch from 3134141 to 09e5c57 Compare March 2, 2026 06:52

alexey-pelykh approved these changes Mar 3, 2026

View reviewed changes

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch from 09e5c57 to 2e33b09 Compare March 9, 2026 10:24

[MIG] sale_cancel_reason: Migration to 19.0

3e76d24

NachoAlesLopez force-pushed the 19.0-mig-sale_cancel_reason-cleaned branch from 2e33b09 to 3e76d24 Compare March 9, 2026 10:27

NachoAlesLopez commented Mar 9, 2026

View reviewed changes

BhaveshHeliconia approved these changes Mar 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0] [MIG] `sale_cancel_reason`#4105

[19.0] [MIG] `sale_cancel_reason`#4105
NachoAlesLopez wants to merge 63 commits intoOCA:19.0from
NachoAlesLopez:19.0-mig-sale_cancel_reason-cleaned

NachoAlesLopez commented Jan 14, 2026

Uh oh!

lfreeke left a comment

Uh oh!

rousseldenis commented Jan 20, 2026

Uh oh!

rousseldenis Jan 20, 2026

Uh oh!

NachoAlesLopez Feb 16, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

alexey-pelykh Mar 1, 2026

Uh oh!

OCA-git-bot commented Mar 1, 2026

Uh oh!

alexey-pelykh left a comment

Uh oh!

NachoAlesLopez Mar 9, 2026 •

edited

Loading

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

NachoAlesLopez commented Jan 14, 2026

Uh oh!

lfreeke left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Jan 20, 2026

Uh oh!

rousseldenis Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

NachoAlesLopez Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 1, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

NachoAlesLopez Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

NachoAlesLopez Mar 9, 2026 •

edited

Loading