[19.0][MIG] base_name_search_improved: Migration to 19.0

[bizzappdev]

No description provided.

[baf-adhoc]

Functional review ok

[lef-adhoc]

@bizzappdev Could you check this PR #3357 ?

[lef-adhoc]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[mav-adhoc]

LGTM

[ced-adhoc]

LGTM

[rov-adhoc]

this should be

def _register_hook(self):
    def make_smart_name_search(original_name_search):
        def wrapper(
            self, name="", domain=None, operator="ilike", limit=100, **kwargs
        ):
            original_results = original_name_search(
                self, name, domain, operator, limit, **kwargs
            )
            if not name or (limit and len(original_results) >= limit):
                return original_results
            seen_ids = {res[0] for res in original_results}
            remaining_limit = limit - len(original_results) if limit else None
            smart_results = Base.name_search(
                self, name=name, domain=domain, operator=operator, limit=remaining_limit
            )
            additional_results = [
                (res_id, res_name)
                for res_id, res_name in smart_results
                if res_id not in seen_ids
            ]
            return original_results + additional_results

Odoo 19.0 introduced a breaking change in the name_search() method signature across all models:

Odoo ≤18.0: name_search(self, name="", args=None, operator="ilike", limit=100)
Odoo 19.0: name_search(self, name="", domain=None, operator="ilike", limit=100)
The parameter args was renamed to domain for consistency with other Odoo API methods.

The module fails in Odoo 19.0 with the error:
TypeError: Base.name_search() got an unexpected keyword argument 'domain'

[rov-adhoc]

@bizzappdev Hi! I just want to ask you if you could see my review.
Thanks in advance!

[ced-adhoc]

LGTM

[mav-adhoc]

This should be:
original_results = original_name_search(
self, name=name, domain=domain, operator=operator, limit=limit, **kwargs
)

In Odoo 19, name_search signature changed from args to domain. Using named arguments ensures parameters are passed correctly regardless of the method signature and how Python unpacks arguments internally. This makes the code more robust and compatible across different Odoo versions and decorators.

[mav-adhoc]

@bizzappdev Hi! I want to ask you if you have seen my review. Thanks!

[gdgellatly]

Static Code Review only LGTM and seems comments dealt to

[gdgellatly]

On further review

[gdgellatly]

In testing we get a weird error here. This is clicking through from a partner on a sale order with Smart Name Search enabled. The error is when smart search is on the fields complete_name, normalized email and phone and it reads

File "/odoo/src/server-tools/base_name_search_improved/models/ir_model.py", line 119, in name_search
    [base_domain, [(rec_name, operator, name.replace(" ", "%"))]]
                                        ^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'replace'

Unfortunately runboat not working so couldn't reproduce. The only special thing going on is there is a name_search super call intervening, however in this case it is a straight passthrough to super

Note it does not fail when using standard search in a list view

[gdgellatly]

Note this is my workaround to get things running, however it is not the fix

diff --git a/base_name_search_improved/models/ir_model.py b/base_name_search_improved/models/ir_model.py
index 5f14d449..78792c01 100644
--- a/base_name_search_improved/models/ir_model.py
+++ b/base_name_search_improved/models/ir_model.py
@@ -96,7 +96,7 @@ class Base(models.AbstractModel):
 
     @api.model
     def name_search(self, name="", domain=None, operator="ilike", limit=100):
-        if not name or not (
+        if not name or not isinstance(name, str) or not (
             self.env.context.get("force_smart_name_search", False)
             or _get_use_smart_name_search(self.sudo())
         ):
@@ -236,7 +236,7 @@ class IrModel(models.Model):
                     limit=limit,
                     **kwargs,
                 )
-                if not name or (limit and len(original_results) >= limit):
+                if not name or not isinstance(name, str) or (limit and len(original_results) >= limit):
                     return original_results
                 seen_ids = {res[0] for res in original_results}
                 remaining_limit = limit - len(original_results) if limit else None