[14.0][FIX] fix white-space display in markdown widget#2433
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@OCA/web-maintainers would someone please review or merge this? |
etobella
left a comment
There was a problem hiding this comment.
Can you use a proper commit description 🙏 ?
Also, it would be nice to show a before and after with screenshots, but well, it is not needed right now.
|
hi @etobella and thank you for the review! what do you mean by proper commit description? isn’t the current message clear enough? source: # hello, this is an h1
## hello, this is an h2
this is an ul:
* an element
* another elementbefore:
after:
|
|
I am talking about the commit message. It is And should include the module name at the begining: |
fix white-space display in markdown widget: add css rule to override the default white-space declaration for text fields (pre-wrap) to ensure the html generated from markdown is correctly displayed.
e51d463 to
1abc34c
Compare
|
thanks for the explanation. done. i didn’t know that the module name was mandatory. with modules with long names it leaves not much space for a meaningful message since the subject is limited to 50 characters. |
|
there is a problem with the tests that seems unrelated to this change. |
hbrunn
left a comment
There was a problem hiding this comment.
old js tests are a mess, and I've given up trying to fix them
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2433-by-etobella-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@etobella given the failing tests, ocabot won't merge this. did so manually |
|
thanks all! |


add css rule to override the default white-space declaration for text fields (pre-wrap) to ensure the html generated from markdown is correctly displayed.