Skip to content

[14.0][FIX] fix white-space display in markdown widget#2433

Merged
hbrunn merged 1 commit intoOCA:14.0from
coopiteasy:14.0-fix-web_widget_text_markdown_whitespace
Sep 4, 2025
Merged

[14.0][FIX] fix white-space display in markdown widget#2433
hbrunn merged 1 commit intoOCA:14.0from
coopiteasy:14.0-fix-web_widget_text_markdown_whitespace

Conversation

@huguesdk
Copy link
Copy Markdown
Member

@huguesdk huguesdk commented Mar 8, 2023

add css rule to override the default white-space declaration for text fields (pre-wrap) to ensure the html generated from markdown is correctly displayed.

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 31, 2025
@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Sep 1, 2025

@OCA/web-maintainers would someone please review or merge this?

Copy link
Copy Markdown
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use a proper commit description 🙏 ?

Also, it would be nice to show a before and after with screenshots, but well, it is not needed right now.

@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Sep 1, 2025

hi @etobella and thank you for the review! what do you mean by proper commit description? isn’t the current message clear enough?

source:

# hello, this is an h1

## hello, this is an h2

this is an ul:

*   an element
*   another element

before:

before

after:

after

@etobella
Copy link
Copy Markdown
Member

etobella commented Sep 1, 2025

I am talking about the commit message.

It is

[FIX] fix white-space display in markdown widget
add css rule to override the default white-space declaration for text
fields (pre-wrap) to ensure the html generated from markdown is
correctly displayed.

And should include the module name at the begining:

[FIX] web_widget_text_markdow: fix white-space display in markdown widget
add css rule to override the default white-space declaration for text
fields (pre-wrap) to ensure the html generated from markdown is
correctly displayed.

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

fix white-space display in markdown widget: add css rule to override the
default white-space declaration for text fields (pre-wrap) to ensure the
html generated from markdown is correctly displayed.
@huguesdk huguesdk force-pushed the 14.0-fix-web_widget_text_markdown_whitespace branch 2 times, most recently from e51d463 to 1abc34c Compare September 1, 2025 13:18
@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Sep 1, 2025

thanks for the explanation. done. i didn’t know that the module name was mandatory. with modules with long names it leaves not much space for a meaningful message since the subject is limited to 50 characters.

@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Sep 1, 2025

there is a problem with the tests that seems unrelated to this change.

Copy link
Copy Markdown
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old js tests are a mess, and I've given up trying to fix them

@etobella
Copy link
Copy Markdown
Member

etobella commented Sep 4, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2433-by-etobella-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 4, 2025
Signed-off-by etobella
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2433-by-etobella-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Copy Markdown
Member

hbrunn commented Sep 4, 2025

@etobella given the failing tests, ocabot won't merge this. did so manually

@hbrunn hbrunn merged commit 01d68c3 into OCA:14.0 Sep 4, 2025
5 of 7 checks passed
@huguesdk
Copy link
Copy Markdown
Member Author

huguesdk commented Sep 5, 2025

thanks all!

@SirPyTech SirPyTech mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants