-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application usage statistics #2387
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3981341
add execution and trends statistics
ssuvorov-fls 05e64a5
Feature readiness
alex-odysseus 53e27a6
Fixing statistics endpoint permission method GET -> POST
alex-odysseus 8e28b98
ATL-8: Atlas Usage Statistics
hernaldourbina 1fe7db0
ATL-8: Addressing userId info
hernaldourbina 462d81d
ATL-8: Updating username logic
hernaldourbina 01c0d51
ATL-8: Adding accesstrends regexp update
hernaldourbina af3f682
ATL-8: Adding userInformation to the response
hernaldourbina 4fe2f04
Minor formatting
alex-odysseus 3233ba3
Log entry added, non-closed resources are correctly handled, file hea…
alex-odysseus 1a431c3
Fixed issue with a method reference in a stream during the docker build
oleg-odysseus 038a60b
Having the controller instantiated without conditions and responding …
alex-odysseus 32c98a7
Removing a condition from the service as well
alex-odysseus 24ebe0c
Correcting StatisticService instantiation
alex-odysseus 82a3ac9
500 Internal Server Error instead of 404 Not Found
alex-odysseus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
261 changes: 261 additions & 0 deletions
261
src/main/java/org/ohdsi/webapi/statistic/controller/StatisticController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,261 @@ | ||
package org.ohdsi.webapi.statistic.controller; | ||
|
||
import com.opencsv.CSVWriter; | ||
|
||
import org.ohdsi.webapi.statistic.dto.AccessTrendDto; | ||
import org.ohdsi.webapi.statistic.dto.AccessTrendsDto; | ||
import org.ohdsi.webapi.statistic.dto.EndpointDto; | ||
import org.ohdsi.webapi.statistic.dto.SourceExecutionDto; | ||
import org.ohdsi.webapi.statistic.dto.SourceExecutionsDto; | ||
import org.ohdsi.webapi.statistic.service.StatisticService; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.beans.factory.annotation.Value; | ||
import org.springframework.stereotype.Controller; | ||
|
||
import javax.ws.rs.Consumes; | ||
import javax.ws.rs.InternalServerErrorException; | ||
import javax.ws.rs.POST; | ||
import javax.ws.rs.Path; | ||
import javax.ws.rs.Produces; | ||
import javax.ws.rs.core.MediaType; | ||
import javax.ws.rs.core.Response; | ||
|
||
import java.io.ByteArrayOutputStream; | ||
import java.io.StringWriter; | ||
import java.time.LocalDate; | ||
import java.time.format.DateTimeFormatter; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
import java.util.stream.Collectors; | ||
|
||
@Controller | ||
@Path("/statistic/") | ||
public class StatisticController { | ||
|
||
private static final Logger log = LoggerFactory.getLogger(StatisticController.class); | ||
|
||
private StatisticService service; | ||
|
||
@Value("${audit.trail.enabled}") | ||
private boolean auditTrailEnabled; | ||
|
||
public enum ResponseFormat { | ||
CSV, JSON | ||
} | ||
|
||
private static final List<String[]> EXECUTION_STATISTICS_CSV_RESULT_HEADER = new ArrayList<String[]>() {{ | ||
add(new String[]{"Date", "Source", "Execution Type"}); | ||
}}; | ||
|
||
private static final List<String[]> EXECUTION_STATISTICS_CSV_RESULT_HEADER_WITH_USER_ID = new ArrayList<String[]>() {{ | ||
add(new String[]{"Date", "Source", "Execution Type", "User ID"}); | ||
}}; | ||
|
||
private static final List<String[]> ACCESS_TRENDS_CSV_RESULT_HEADER = new ArrayList<String[]>() {{ | ||
add(new String[]{"Date", "Endpoint"}); | ||
}}; | ||
|
||
private static final List<String[]> ACCESS_TRENDS_CSV_RESULT_HEADER_WITH_USER_ID = new ArrayList<String[]>() {{ | ||
add(new String[]{"Date", "Endpoint", "User ID"}); | ||
}}; | ||
|
||
@Autowired | ||
public StatisticController(StatisticService service) { | ||
this.service = service; | ||
} | ||
|
||
/** | ||
* Returns execution statistics | ||
* @param executionStatisticsRequest - filter settings for statistics | ||
*/ | ||
@POST | ||
@Path("/executions") | ||
@Produces(MediaType.APPLICATION_JSON) | ||
@Consumes(MediaType.APPLICATION_JSON) | ||
public Response executionStatistics(ExecutionStatisticsRequest executionStatisticsRequest) { | ||
if (!auditTrailEnabled) { | ||
throw new InternalServerErrorException("Audit Trail functionality should be enabled (audit.trail.enabled) to serve this endpoint"); | ||
} | ||
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd"); | ||
boolean showUserInformation = executionStatisticsRequest.isShowUserInformation(); | ||
|
||
SourceExecutionsDto sourceExecutions = service.getSourceExecutions(LocalDate.parse(executionStatisticsRequest.getStartDate(), formatter), | ||
LocalDate.parse(executionStatisticsRequest.getEndDate(), formatter), executionStatisticsRequest.getSourceKey(), showUserInformation); | ||
|
||
if (ResponseFormat.CSV.equals(executionStatisticsRequest.getResponseFormat())) { | ||
return prepareExecutionResultResponse(sourceExecutions.getExecutions(), "execution_statistics.zip", showUserInformation); | ||
} else { | ||
return Response.ok(sourceExecutions).build(); | ||
} | ||
} | ||
|
||
/** | ||
* Returns access trends statistics | ||
* @param accessTrendsStatisticsRequest - filter settings for statistics | ||
*/ | ||
@POST | ||
@Path("/accesstrends") | ||
@Produces(MediaType.APPLICATION_JSON) | ||
@Consumes(MediaType.APPLICATION_JSON) | ||
public Response accessStatistics(AccessTrendsStatisticsRequest accessTrendsStatisticsRequest) { | ||
if (!auditTrailEnabled) { | ||
throw new InternalServerErrorException("Audit Trail functionality should be enabled (audit.trail.enabled) to serve this endpoint"); | ||
} | ||
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd"); | ||
boolean showUserInformation = accessTrendsStatisticsRequest.isShowUserInformation(); | ||
|
||
AccessTrendsDto trends = service.getAccessTrends(LocalDate.parse(accessTrendsStatisticsRequest.getStartDate(), formatter), | ||
LocalDate.parse(accessTrendsStatisticsRequest.getEndDate(), formatter), accessTrendsStatisticsRequest.getEndpoints(), showUserInformation); | ||
|
||
if (ResponseFormat.CSV.equals(accessTrendsStatisticsRequest.getResponseFormat())) { | ||
return prepareAccessTrendsResponse(trends.getTrends(), "execution_trends.zip", showUserInformation); | ||
} else { | ||
return Response.ok(trends).build(); | ||
} | ||
} | ||
|
||
private Response prepareExecutionResultResponse(List<SourceExecutionDto> executions, String filename, boolean showUserInformation) { | ||
List<String[]> data = executions.stream() | ||
.map(execution -> showUserInformation | ||
? new String[]{execution.getExecutionDate(), execution.getSourceName(), execution.getExecutionName(), execution.getUserId()} | ||
: new String[]{execution.getExecutionDate(), execution.getSourceName(), execution.getExecutionName()} | ||
) | ||
.collect(Collectors.toList()); | ||
return prepareResponse(data, filename, showUserInformation ? EXECUTION_STATISTICS_CSV_RESULT_HEADER_WITH_USER_ID : EXECUTION_STATISTICS_CSV_RESULT_HEADER); | ||
} | ||
|
||
private Response prepareAccessTrendsResponse(List<AccessTrendDto> trends, String filename, boolean showUserInformation) { | ||
List<String[]> data = trends.stream() | ||
.map(trend -> showUserInformation | ||
? new String[]{trend.getExecutionDate().toString(), trend.getEndpointName(), trend.getUserID()} | ||
: new String[]{trend.getExecutionDate().toString(), trend.getEndpointName()} | ||
) | ||
.collect(Collectors.toList()); | ||
return prepareResponse(data, filename, showUserInformation ? ACCESS_TRENDS_CSV_RESULT_HEADER_WITH_USER_ID : ACCESS_TRENDS_CSV_RESULT_HEADER); | ||
} | ||
|
||
private Response prepareResponse(List<String[]> data, String filename, List<String[]> header) { | ||
try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
StringWriter sw = new StringWriter(); | ||
CSVWriter csvWriter = new CSVWriter(sw, ',', CSVWriter.DEFAULT_QUOTE_CHARACTER, CSVWriter.DEFAULT_ESCAPE_CHARACTER)) { | ||
|
||
csvWriter.writeAll(header); | ||
csvWriter.writeAll(data); | ||
csvWriter.flush(); | ||
baos.write(sw.getBuffer().toString().getBytes()); | ||
|
||
return Response | ||
.ok(baos) | ||
.type(MediaType.APPLICATION_OCTET_STREAM) | ||
.header("Content-Disposition", String.format("attachment; filename=\"%s\"", filename)) | ||
.build(); | ||
} catch (Exception ex) { | ||
log.error("An error occurred while building a response"); | ||
throw new RuntimeException(ex); | ||
alex-odysseus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
public static final class ExecutionStatisticsRequest { | ||
// Format - yyyy-MM-dd | ||
String startDate; | ||
// Format - yyyy-MM-dd | ||
String endDate; | ||
String sourceKey; | ||
ResponseFormat responseFormat; | ||
boolean showUserInformation; | ||
|
||
public String getStartDate() { | ||
return startDate; | ||
} | ||
|
||
public void setStartDate(String startDate) { | ||
this.startDate = startDate; | ||
} | ||
|
||
public String getEndDate() { | ||
return endDate; | ||
} | ||
|
||
public void setEndDate(String endDate) { | ||
this.endDate = endDate; | ||
} | ||
|
||
public String getSourceKey() { | ||
return sourceKey; | ||
} | ||
|
||
public void setSourceKey(String sourceKey) { | ||
this.sourceKey = sourceKey; | ||
} | ||
|
||
public ResponseFormat getResponseFormat() { | ||
return responseFormat; | ||
} | ||
|
||
public void setResponseFormat(ResponseFormat responseFormat) { | ||
this.responseFormat = responseFormat; | ||
} | ||
|
||
public boolean isShowUserInformation() { | ||
return showUserInformation; | ||
} | ||
|
||
public void setShowUserInformation(boolean showUserInformation) { | ||
this.showUserInformation = showUserInformation; | ||
} | ||
} | ||
|
||
public static final class AccessTrendsStatisticsRequest { | ||
// Format - yyyy-MM-dd | ||
String startDate; | ||
// Format - yyyy-MM-dd | ||
String endDate; | ||
// Key - method (POST, GET) | ||
// Value - endpoint ("{}" can be used as a placeholder, will be converted to ".*" in regular expression) | ||
List<EndpointDto> endpoints; | ||
ResponseFormat responseFormat; | ||
boolean showUserInformation; | ||
|
||
public String getStartDate() { | ||
return startDate; | ||
} | ||
|
||
public void setStartDate(String startDate) { | ||
this.startDate = startDate; | ||
} | ||
|
||
public String getEndDate() { | ||
return endDate; | ||
} | ||
|
||
public void setEndDate(String endDate) { | ||
this.endDate = endDate; | ||
} | ||
|
||
public List<EndpointDto> getEndpoints() { | ||
return endpoints; | ||
} | ||
|
||
public void setEndpoints(List<EndpointDto> endpoints) { | ||
this.endpoints = endpoints; | ||
} | ||
|
||
public ResponseFormat getResponseFormat() { | ||
return responseFormat; | ||
} | ||
|
||
public void setResponseFormat(ResponseFormat responseFormat) { | ||
this.responseFormat = responseFormat; | ||
} | ||
|
||
public boolean isShowUserInformation() { | ||
return showUserInformation; | ||
} | ||
|
||
public void setShowUserInformation(boolean showUserInformation) { | ||
this.showUserInformation = showUserInformation; | ||
} | ||
} | ||
} |
37 changes: 37 additions & 0 deletions
37
src/main/java/org/ohdsi/webapi/statistic/dto/AccessTrendDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
package org.ohdsi.webapi.statistic.dto; | ||
|
||
public class AccessTrendDto { | ||
private String endpointName; | ||
private String executionDate; | ||
private String userID; | ||
|
||
public AccessTrendDto(String endpointName, String executionDate, String userID) { | ||
this.endpointName = endpointName; | ||
this.executionDate = executionDate; | ||
this.userID = userID; | ||
} | ||
|
||
public String getEndpointName() { | ||
return endpointName; | ||
} | ||
|
||
public void setEndpointName(String endpointName) { | ||
this.endpointName = endpointName; | ||
} | ||
|
||
public String getExecutionDate() { | ||
return executionDate; | ||
} | ||
|
||
public void setExecutionDate(String executionDate) { | ||
this.executionDate = executionDate; | ||
} | ||
|
||
public String getUserID() { | ||
return userID; | ||
} | ||
|
||
public void setUserID(String userID) { | ||
this.userID = userID; | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
src/main/java/org/ohdsi/webapi/statistic/dto/AccessTrendsDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package org.ohdsi.webapi.statistic.dto; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class AccessTrendsDto { | ||
private List<AccessTrendDto> trends = new ArrayList<>(); | ||
|
||
public AccessTrendsDto(List<AccessTrendDto> trends) { | ||
this.trends = trends; | ||
} | ||
|
||
public List<AccessTrendDto> getTrends() { | ||
return trends; | ||
} | ||
} |
32 changes: 32 additions & 0 deletions
32
src/main/java/org/ohdsi/webapi/statistic/dto/EndpointDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package org.ohdsi.webapi.statistic.dto; | ||
|
||
public class EndpointDto { | ||
String method; | ||
String urlPattern; | ||
String userId; | ||
|
||
public String getMethod() { | ||
return method; | ||
} | ||
|
||
public void setMethod(String method) { | ||
this.method = method; | ||
} | ||
|
||
public String getUrlPattern() { | ||
return urlPattern; | ||
} | ||
|
||
public void setUrlPattern(String urlPattern) { | ||
this.urlPattern = urlPattern; | ||
} | ||
|
||
public String getUserId() { | ||
return userId; | ||
} | ||
|
||
public void setUserId(String userId) { | ||
this.userId = userId; | ||
} | ||
} | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both CSV and JSON output formats should be supported