Temporal annual distribution functionality and temporal FeatureExtraction capability enablement #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like only the 'annual' flag is currently transferred from the client which leads to storing NULL in the database
…e covariates comparison feature
[ATL-10] Added an option to exclude creating comparative items for the covariates comparison feature
…ke it was done for the annual Feature Analysis flag
…l distribution functionality should be available
alex-odysseus
commented
Aug 28, 2024
| @@ -26,4 +26,42 @@ CREATE TABLE @results_schema.cc_results | |||
| aggregate_id INTEGER, | |||
| aggregate_name VARCHAR(1000), | |||
| missing_means_zero INTEGER | |||
| ); | |||
|
|
|||
| IF OBJECT_ID('@results_schema.cc_temporal_results') IS NULL | |||
There was a problem hiding this comment.
Similar notation as for the table above should be used
IF OBJECT_ID('@results_schema.table', 'U') IS NULL
alex-odysseus
commented
Aug 28, 2024
| 'DemographicsPriorObservationTime', | ||
| 'DemographicsPostObservationTime', | ||
| 'DemographicsTimeInCohort', | ||
| 'DemographicsIndexYearMonth' |
There was a problem hiding this comment.
Is the list final?
There was a problem hiding this comment.
…e covariates comparison feature
[ATL-10] Added an option to exclude creating comparative items for the covariates comparison feature
…ke it was done for the annual Feature Analysis flag
… with missing design
Fixed NullPointerException during saving of a cohort characterization with missing design
…nual-distribution
…ts schema DDL Supplementing Feature Analyses names from FeatureExtraction for the temporal feature
|
Chris, please pull the code @chrisknoll |
|
Error when generating: This came from a copy of an existing CC, where I switched on the new options in the design. Attached is sample CC example: CC_TestCase.txt |
chrisknoll
requested changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2331 (temporal annual distribution requirement)
Cohort Characterization Controller has been extended with a new endpoint
GET /generation/{generationId}/temporalresultTemporal annual distribution and temporal Cohort Characterization analysis execution results are selected from newly introduced tables in the result schema - cc_temporal_results and cc_temporal_annual_results
Each Feature Analysis has been extended with two attributes indicating their temporal and temporal annual distribution properties depending on their actual support by FeatureExtraction