add jar build #2473
Open
add jar build #2473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The change will break existing Dockerfile and build procedure. It should be updated: |
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the OHDSI WebAPI project by transitioning from WAR-based deployment to an executable Spring Boot JAR with embedded Tomcat as the primary packaging format. The changes aim to simplify deployment by eliminating the need for external application servers while maintaining backward compatibility through a Maven profile for WAR packaging.
Key Changes:
- Switched default packaging from WAR to executable JAR with embedded Tomcat server
- Updated WebApi class to use standard SpringApplication.run() instead of SpringBootServletInitializer
- Added comprehensive Quick Start Guide and deployment documentation to README
- Modified Docker build to run the executable JAR directly instead of exploded WAR structure
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/ohdsi/webapi/WebApi.java | Removed SpringBootServletInitializer extension and WAR-specific initialization code, converting to standalone JAR application entry point |
| pom.xml | Changed packaging type from WAR to JAR, removed provided scopes from Tomcat dependencies, added WAR profile for legacy deployment support |
| README.md | Added extensive Quick Start Guide, deployment options, configuration examples, and troubleshooting sections for JAR-based deployment |
| Dockerfile | Simplified to copy and execute the JAR file directly instead of exploding WAR contents |
| .github/workflows/release.yaml | Updated to build and upload both JAR and WAR artifacts to GitHub releases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the OHDSI WebAPI project by switching its primary packaging from a deployable WAR to an executable Spring Boot JAR with embedded Tomcat, and updates the build, Docker, and documentation accordingly. The changes simplify deployment (no external app server required), streamline configuration, and improve the developer experience. WAR packaging is still available via a Maven profile for legacy use cases.