Skip to content

Conversation

@maya-trenser
Copy link

Context

Changes & Results

This PR updates the registerHotkeys method in HotkeysManager to store the complete hotkey definition when registering a hotkey. Previously, only partial information was saved, limiting the ability to reference hotkey metadata elsewhere in the application.

With this change:

  • All parameters from the hotkey definition are retained in the manager.
  • Downstream consumers can access the full definition for specialized handling, such as dynamic hotkey management or context-aware logic.

This improves flexibility for handling hotkeys beyond simple key-to-command binding while preserving backward-compatible registration behavior.

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

…keysManager, enabling downstream consumers to access all hotkey parameters for custom handling.
@netlify
Copy link

netlify bot commented Dec 30, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 2cb5797
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6964bdb3297b2b0008078347
😎 Deploy Preview https://deploy-preview-5682--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant