Skip to content

feat(Hotkey): Persist complete hotkey definition #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maya-trenser wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(Hotkey): Persist complete hotkey definition #5682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cba8ae
Modified registerHotkeys to persist the full hotkey definition in Hot…
maya-trenser Dec 30, 2025
2cb5797
Merge branch 'master' into feat-save-full-hotkey-definition
maya-trenser Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions platform/core/src/classes/HotkeysManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,14 +227,8 @@ export class HotkeysManager {
* @param hotkey - The hotkey definition object.
* @throws {Error} Throws an error if no commandName is provided.
*/
registerHotkeys({
commandName,
commandOptions = {},
context,
keys,
label,
isEditable,
}: Hotkey): void {
registerHotkeys(hotkeyDefinition: Hotkey): void {
const { commandName, commandOptions = {}, context, keys } = hotkeyDefinition;
if (!commandName) {
throw new Error(`No command was defined for hotkey "${keys}"`);
}
Expand All @@ -256,7 +250,7 @@ export class HotkeysManager {
this._unbindHotkeys(commandName, existingHotkey.keys);
}

this.hotkeyDefinitions[commandHash] = { commandName, commandOptions, keys, label, isEditable };
this.hotkeyDefinitions[commandHash] = { ...hotkeyDefinition };
this._bindHotkeys(commandName, commandOptions, context, keys);
}

Expand Down