fix(bridge): clear stale LiFi pending transfers#365
Open
dewanshparashar wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents LiFi transfers from remaining “pending” indefinitely when the cached source tx hash never lands on-chain, by cross-checking the source transaction against the chain before relying on LiFi’s status endpoint.
Changes:
- Added a 30-minute grace window and on-chain vetting for LiFi source transactions.
- Marked transfers as terminal
FAILUREwhen the source tx is reverted or dropped (no receipt + node no longer has the tx after the grace window).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dewanshparashar
force-pushed
the
fix/vet-stale-lifi-pending-transfers
branch
from
June 19, 2026 15:08
5125cfd to
b99cbf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A LiFi transfer gets cached as "pending" as soon as the wallet hands back a source tx hash. If that transaction never actually lands on-chain (reverted, or dropped from the mempool and never mined), the entry stays "pending" forever — LiFi's status API keeps reporting PENDING for a hash it never saw, so nothing ever reconciles it. This is what a user hit: two transfers stuck pending in their browser, funds still on the source chain.
This adds a check in getUpdatedLifiTransfer that vets the cached source tx against the chain before trusting LiFi's status:
Once marked failed the entry leaves the pending list and stops being re-polled.
Fixes SUP-1452