fix classic ChildToParentMessage.hasExecuted #614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two adjacent bugs in ChildToParentMessageClassic.hasExecuted:
Both bugs can cause
status
to returnUNCOMFIRMED
when it should returnCONFIRMED
E.g., see
https://retryable-dashboard.arbitrum.io/tx/0x9cea73b8c22cfcb12bc66be277d503ef6676b4e62024ed3dc4350953da235817 for a 1 example and
https://retryable-dashboard.arbitrum.io/tx/0xb68ab209d47527cbbaf8a59ac37243a150e3ed2daed74508fb645830a8f3ada9 for for a 2 example.
This ensures all reverts that other than those caused by improper inputs return false.