Skip to content

Conversation

DZGoldman
Copy link
Contributor

This fixes two adjacent bugs in ChildToParentMessageClassic.hasExecuted:

  1. ChildToParentMessages whose proper execution reverts throw in hasExecuted, when they should return false
  2. ChildToParentMessages that use the classic outbox VERSION_NUMBER=0 throw since their revert message isn't handled ( v0 vs v1).
    Both bugs can cause status to return UNCOMFIRMED when it should return CONFIRMED
    E.g., see

https://retryable-dashboard.arbitrum.io/tx/0x9cea73b8c22cfcb12bc66be277d503ef6676b4e62024ed3dc4350953da235817 for a 1 example and

https://retryable-dashboard.arbitrum.io/tx/0xb68ab209d47527cbbaf8a59ac37243a150e3ed2daed74508fb645830a8f3ada9 for for a 2 example.

This ensures all reverts that other than those caused by improper inputs return false.

Copy link

cla-bot bot commented Sep 24, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign one of the linked documents below to get yourself added. If you're an independent Individual please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=1353a816-a9c1-47ba-847e-ec79f0f23d31&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. If you're with a company (corporate) please sign this form: https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=2b5fe8ba-51d4-4980-b4ee-605d66e675d4&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2. To agree to the CLA license, please fill out one of the attached forms.

@DZGoldman
Copy link
Contributor Author

CLA link errors with "Cannot read properties of undefined (reading 'nextAction')"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant