Skip to content

fix classic ChildToParentMessage.hasExecuted #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −3
Open

fix classic ChildToParentMessage.hasExecuted #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions packages/sdk/src/lib/message/ChildToParentMessageClassic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { ArbSdkError } from '../dataEntities/errors'
import { EventArgs } from '../dataEntities/event'
import { ChildToParentMessageStatus } from '../dataEntities/message'
import { getArbitrumNetwork } from '../dataEntities/networks'
import { ErrorCode, Logger } from '@ethersproject/logger'

export interface MessageBatchProofInfo {
/**
Expand Down Expand Up @@ -323,9 +324,25 @@ export class ChildToParentMessageReaderClassic extends ChildToParentMessageClass
)
return false
} catch (err) {
const e = err as Error
if (e?.message?.toString().includes('ALREADY_SPENT')) return true
if (e?.message?.toString().includes('NO_OUTBOX_ENTRY')) return false
const e = err as unknown as { code: ErrorCode; reason: string }

if (e.code === Logger.errors.CALL_EXCEPTION) {
if (e.reason === 'ALREADY_SPENT') return true

// throw for reverts in Outbox that result from malformed inputs
if (
['PROOF_TOO_LONG', 'PATH_NOT_MINIMAL', 'BAD_ROOT'].some(
(revertReason: string) => revertReason === e.reason
)
)
throw e

// return false for all other reverts
// this includes other reverts in the outbox like NO_OUTBOX / NO_OUTBOX_ENTRY
// as well as reverts within the execution of the ChildToParent message itself
return false
}

throw e
}
}
Expand Down