Skip to content

Add an option to start re validation from a specified block and end at a specified block #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add an option to start re validation from a specified block and end at a specified block #2893

wants to merge 22 commits into from
+143 −1

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jan 23, 2025 •
edited
Loading

Fixes: NIT-3017, NIT-3019

@amsanghi amsanghi marked this pull request as ready for review January 23, 2025 08:53
@amsanghi amsanghi changed the title [NIT-3017] Add an option to start re validation from a specified block Add an option to start re validation from a specified block Jan 30, 2025
@amsanghi amsanghi changed the title Add an option to start re validation from a specified block Add an option to start re validation from a specified block and end at a specified block Jan 30, 2025
diegoximenes
diegoximenes requested changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@diegoximenes diegoximenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
How about adding some tests related to this new behavior?

tsahee
tsahee requested changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good.
Some small comments.

@amsanghi amsanghi requested a review from tsahee April 7, 2025 12:45
@amsanghi amsanghi removed their assignment Apr 7, 2025
tsahee
tsahee previously approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee assigned diegoximenes and unassigned tsahee Apr 10, 2025
diegoximenes
diegoximenes requested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@diegoximenes diegoximenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a test related to the new behavior?

@amsanghi
Copy link
Contributor Author

How about adding a test related to the new behavior?

Done.

@amsanghi amsanghi requested a review from diegoximenes April 29, 2025 16:45
@amsanghi amsanghi assigned diegoximenes and unassigned amsanghi Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee left review comments

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

@diegoximenes diegoximenes Awaiting requested review from diegoximenes

Requested changes must be addressed to merge this pull request.

Assignees

@diegoximenes diegoximenes

Labels
design-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amsanghi @diegoximenes @joshuacolvin0 @tsahee @eljobe