Skip to content

Add an option to start re validation from a specified block and end at a specified block #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 56 additions & 1 deletion staker/block_validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,21 @@ func (c *BlockValidatorConfig) Validate() error {
}
}
}
if c.Dangerous.Revalidation.EndBlock > 0 && c.Dangerous.Revalidation.EndBlock < c.Dangerous.Revalidation.StartBlock {
return fmt.Errorf("revalidation end block %d is before start block %d", c.Dangerous.Revalidation.EndBlock, c.Dangerous.Revalidation.StartBlock)
}
return nil
}

type BlockValidatorDangerousConfig struct {
ResetBlockValidation bool `koanf:"reset-block-validation"`
ResetBlockValidation bool `koanf:"reset-block-validation"`
Revalidation RevalidationConfig `koanf:"revalidation"`
}

type RevalidationConfig struct {
StartBlock uint64 `koanf:"start-block"`
EndBlock uint64 `koanf:"end-block"`
QuitAfterRevalidation bool `koanf:"quit-after-revalidation"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it ever make sense to continue running after revalidating blocks? How about simply quitting if end-block non-zero?

}

type BlockValidatorConfigFetcher func() *BlockValidatorConfig
Expand All @@ -199,6 +209,13 @@ func BlockValidatorConfigAddOptions(prefix string, f *pflag.FlagSet) {

func BlockValidatorDangerousConfigAddOptions(prefix string, f *pflag.FlagSet) {
f.Bool(prefix+".reset-block-validation", DefaultBlockValidatorDangerousConfig.ResetBlockValidation, "resets block-by-block validation, starting again at genesis")
RevalidationConfigAddOptions(prefix+".revalidation", f)
}

func RevalidationConfigAddOptions(prefix string, f *pflag.FlagSet) {
f.Uint64(prefix+".start-block", DefaultBlockValidatorDangerousConfig.Revalidation.StartBlock, "start revalidation from this block")
f.Uint64(prefix+".end-block", DefaultBlockValidatorDangerousConfig.Revalidation.EndBlock, "end revalidation at this block")
f.Bool(prefix+".quit-after-revalidation", DefaultBlockValidatorDangerousConfig.Revalidation.QuitAfterRevalidation, "exit node after revalidation is done")
}

var DefaultBlockValidatorConfig = BlockValidatorConfig{
Expand Down Expand Up @@ -239,6 +256,13 @@ var TestBlockValidatorConfig = BlockValidatorConfig{

var DefaultBlockValidatorDangerousConfig = BlockValidatorDangerousConfig{
ResetBlockValidation: false,
Revalidation: DefaultRevalidationConfig,
}

var DefaultRevalidationConfig = RevalidationConfig{
StartBlock: 0,
EndBlock: 0,
QuitAfterRevalidation: false,
}

type valStatusField uint32
Expand Down Expand Up @@ -327,6 +351,29 @@ func NewBlockValidator(
PosInBatch: 0,
}
}
if config().Dangerous.Revalidation.StartBlock > 0 {
startBlock := config().Dangerous.Revalidation.StartBlock
messageCount, err := inbox.GetBatchMessageCount(startBlock - 1)
if err != nil {
return nil, err
}
res := &execution.MessageResult{}
if messageCount > 0 {
res, err = streamer.ResultAtMessageIndex(messageCount - 1)
if err != nil {
return nil, err
}
}
startPos, _, err := statelessBlockValidator.GlobalStatePositionsAtCount(messageCount)
if err != nil {
return nil, err
}
gs := BuildGlobalState(*res, startPos)
err = ret.writeLastValidated(gs, nil)
if err != nil {
return nil, err
}
}
streamer.SetBlockValidator(ret)
inbox.SetBlockValidator(ret)
if config().MemoryFreeLimit != "" {
Expand Down Expand Up @@ -796,6 +843,14 @@ func (v *BlockValidator) iterativeValidationPrint(ctx context.Context) time.Dura
}
log.Info("validated execution", "messageCount", printedCount, "globalstate", validated.GlobalState, "WasmRoots", validated.WasmRoots)
v.lastValidInfoPrinted = validated
revalidationConfig := v.config().Dangerous.Revalidation
if revalidationConfig.EndBlock > 0 && validated.GlobalState.Batch >= revalidationConfig.EndBlock {
if revalidationConfig.QuitAfterRevalidation {
v.fatalErr <- fmt.Errorf("revalidation done from %d to %d", revalidationConfig.StartBlock, revalidationConfig.EndBlock)
} else {
v.StopOnly()
}
}
return time.Second
}

Expand Down
Loading