Skip to content

Conversation

MishkaRogachev
Copy link
Contributor

Fixes NIT-3978

Add weights to resource constraints and corresponding tests

@MishkaRogachev MishkaRogachev force-pushed the add-weights-to-resource-constraints branch from a24ae3c to 338d10b Compare October 8, 2025 14:20
Copy link

github-actions bot commented Oct 8, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2140 2 2138 0
View the top 2 failed tests by shortest run time
TestVersion30
Stack Traces | 13.050s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 455218 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4082230, 0xc0a3ceae00}, {0x4040480, 0xc0d48ba120}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0a3ceae00, {0x4040480, 0xc0d48ba120}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0a3ceae00, 0x1e, {0xc0853e7db0, 0x6, 0x4f5dc9?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc0a3ceae00?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc0a3ceae00, 0x3cca7e0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (13.05s)
TestEthSyncing
Stack Traces | 79.420s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[10-14|13:52:53.881] Journaled pathdb diff layer              root=516dc0..f0d4c3 parent=456eac..b585c2 id=41                 block=40
DEBUG[10-14|13:52:53.881] Journaled pathdb diff layer              root=544dc1..674b0f parent=516dc0..f0d4c3 id=42                 block=41
DEBUG[10-14|13:52:53.881] Journaled pathdb diff layer              root=6e127d..79bf28 parent=544dc1..674b0f id=43                 block=42
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=237dee..ece7fb parent=6e127d..79bf28 id=44                 block=43
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=8566b3..382a98 parent=237dee..ece7fb id=45                 block=44
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=2375b4..7b38db parent=8566b3..382a98 id=46                 block=45
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=eb3502..30e2bf parent=2375b4..7b38db id=47                 block=46
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=a15c4c..030fc0 parent=eb3502..30e2bf id=48                 block=47
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=b510d6..191b67 parent=a15c4c..030fc0 id=49                 block=48
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=9d12ce..d28ed4 parent=b510d6..191b67 id=50                 block=49
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=e2b87f..443d89 parent=9d12ce..d28ed4 id=51                 block=50
DEBUG[10-14|13:52:53.882] Journaled pathdb diff layer              root=6ffc31..bb0d37 parent=e2b87f..443d89 id=52                 block=51
DEBUG[10-14|13:52:53.883] Journaled pathdb diff layer              root=f7900c..7df336 parent=6ffc31..bb0d37 id=53                 block=52
DEBUG[10-14|13:52:53.883] Journaled pathdb diff layer              root=cb6461..8ddea4 parent=f7900c..7df336 id=54                 block=53
DEBUG[10-14|13:52:53.883] Journaled pathdb diff layer              root=c59d6a..36f38b parent=cb6461..8ddea4 id=55                 block=54
DEBUG[10-14|13:52:53.883] Journaled pathdb diff layer              root=858bef..b686b8 parent=c59d6a..36f38b id=56                 block=55
DEBUG[10-14|13:52:53.883] Journaled pathdb diff layer              root=a0cfe0..258df7 parent=858bef..b686b8 id=57                 block=56
INFO [10-14|13:52:53.884] Persisted dirty state to disk            size=285.58KiB  elapsed=6.678ms
INFO [10-14|13:52:53.884] Blockchain stopped
TRACE[10-14|13:52:53.884] P2P networking is spinning down

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev MishkaRogachev force-pushed the add-weights-to-resource-constraints branch from 36bdec5 to 36981bd Compare October 8, 2025 20:27
@MishkaRogachev
Copy link
Contributor Author

the code was slightly modified in #3804, closing this PR for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants