-
Notifications
You must be signed in to change notification settings - Fork 644
Add resource constraints to arbos storage and precompiles for resource constraints #3804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MishkaRogachev
wants to merge
9
commits into
master
Choose a base branch
from
add-resource-constraints-to-arbos-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+963
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 7 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
5d85d4f
to
534792d
Compare
gligneul
reviewed
Oct 10, 2025
|
||
// Load decodes ResourceConstraints from storage using RLP. | ||
// If storage is empty, returns an empty ResourceConstraints. | ||
func (src *StorageResourceConstraints) Load() (*ResourceConstraints, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should add a field with a version number, in case we want to change this in the future.
89cca35
to
dfaec7c
Compare
This was referenced Oct 14, 2025
dfaec7c
to
11dc0da
Compare
7fe4a4d
to
83e865f
Compare
53edd6f
to
e1d876d
Compare
e1d876d
to
e2bfb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NIT-3963, closes NIT-3978 and closes NIT-3488
Depends on:
Implemented: