getNextBlockToRead does not deped on FillInBatchGasField

[tsahee]

FillInBatchGas might fail, esp. if reading the last batch failed. Dont depend on it for getNextBlockToRead

[github-actions]

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
2142	5	2137	0

View the top 3 failed tests by shortest run time

TestDataStreaming_PositiveScenario/Many_senders,_long_messages

Stack Traces | 0.250s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 156
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
WARN [10-16|02:41:12.224] Served datastreaming_start               conn=127.0.0.1:42540 reqid=246 duration="125.334µs" err="too much time has elapsed since request was signed"
INFO [10-16|02:41:12.224] rpc response                             method=datastreaming_start logId=246 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x68f05b47\", \"0x34\", \"0xd9\", \"0x2b8d\", \"0xa\", \"0x592fb4e7ba50d3e1217630a8ba50266d097b8813952edcfc8c8c5b882abc8aba28b19825b334fba3992e9ff470a8f972df20e6b219ffbf60bd70e172a133f83100\"]" errorData=null
    protocol_test.go:248: goroutine 161 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1567e90, 0xc00064bc00}, {0x154d960, 0xc0017128e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 156
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.25s)

TestDataStreaming_PositiveScenario

Stack Traces | 0.290s run time

=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.29s)

TestDataStreaming_ServerAbortsProtocolAfterExpiry

Stack Traces | 2.000s run time

=== RUN   TestDataStreaming_ServerAbortsProtocolAfterExpiry
    protocol_test.go:144: 
        	Error Trace:	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:144
        	Error:      	An error is expected but got nil.
        	Test:       	TestDataStreaming_ServerAbortsProtocolAfterExpiry
--- FAIL: TestDataStreaming_ServerAbortsProtocolAfterExpiry (2.00s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov