[NIT-4019] Exclude BatchDataStats from feed for old ArbOS versions

[pmikolajczyk41]

Changes:

• rename ExecutionBatchPoster interface to ArbOSVersionGetter and make its method async
• inherit ArbOSVersionGetter in ExecutionClient
• excude BatchDataStats from feed for ArbOS versions before 50
• add // lint:require-exhaustive-initialization for MessageWithMetadataAndBlockInfo
• use MessageWithMetadataAndBlockInfo in the broadcaster's API instead of all its components separately
• extend BroadcastFeedMessage with ArbOS version

[github-actions]

❌ 4 Tests Failed:

Tests completed	Failed	Passed	Skipped
2144	4	2140	0

View the top 3 failed tests by shortest run time

TestTimeboostTxsTimeoutByBlock

Stack Traces | 1.530s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
TRACE[10-16|19:47:15.593] Handled RPC response                     reqid=57    duration="1.713µs"
    timeboost_test.go:1628: goroutine 1459020 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4083810, 0xc05c0e6a80}, {0x4041a40, 0xc0c72668d0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc05c0e6a80, {0x4041a40, 0xc0c72668d0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.setupExpressLaneAuction(0xc05c0e6a80, {0xc02ae54300, 0x60}, {0x4061588, 0xc0cebdf1d0}, 0x0, 0x5)
        	/home/runner/work/nitro/nitro/system_tests/timeboost_test.go:1628 +0x181a
        github.com/offchainlabs/nitro/system_tests.TestTimeboostTxsTimeoutByBlock(0xc05c0e6a80)
        	/home/runner/work/nitro/nitro/system_tests/timeboost_test.go:62 +0xa5
        testing.tRunner(0xc05c0e6a80, 0x3ccbaf8)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    timeboost_test.go:1628: �[31;1m [] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 7 state: 8 �[0;0m
WARN [10-16|19:47:15.594] coordinator failed finding sequencer wanting lockout err="context canceled"
--- FAIL: TestTimeboostTxsTimeoutByBlock (1.53s)

TestVersion30

Stack Traces | 5.440s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
ERROR[10-16|19:50:34.477] a large batch posting backlog exists     recentlyHitL1Bounds=false currentPosition=51 messageCount=136 messagesPerBatch=1 postedMessages=1 unpostedMessages=85 batchBacklogEstimate=85
    precompile_inclusion_test.go:90: goroutine 455079 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4083810, 0xc03d5cbdc0}, {0x4041a40, 0xc109b145a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc03d5cbdc0, {0x4041a40, 0xc109b145a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc03d5cbdc0, 0x1e, {0xc08c96fdb0, 0x6, 0x0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc03d5cbdc0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc03d5cbdc0, 0x3ccbb58)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
ERROR[10-16|19:50:39.360] a large batch posting backlog exists     recentlyHitL1Bounds=false currentPosition=72 messageCount=155 messagesPerBatch=1 postedMessages=1 unpostedMessages=83 batchBacklogEstimate=83
--- FAIL: TestVersion30 (5.44s)

TestEthSyncing

Stack Traces | 24.120s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [10-16|19:47:50.411] New Key                                  name=Validator         Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
DEBUG[10-16|19:47:50.412] Served eth_getTransactionReceipt         reqid=282  duration="364.782µs"
INFO [10-16|19:47:50.412] New Key                                  name=User              Address=0x7E23C8862920797d81916d62c274dd9217113e28
INFO [10-16|19:47:50.412] New Key                                  name=User2             Address=0x0C709F340F0BB2e361229e345B7e26999d0969Ab
TRACE[10-16|19:47:50.412] Handled RPC response                     reqid=282  duration="2.314µs"
DEBUG[10-16|19:47:50.412] Served eth_blockNumber                   reqid=9    duration="13.355µs"
TRACE[10-16|19:47:50.412] Handled RPC response                     reqid=9    duration=801ns
DEBUG[10-16|19:47:50.412] Served eth_getTransactionReceipt         reqid=376  duration="79.278µs"
TRACE[10-16|19:47:50.412] Handled RPC response                     reqid=376  duration="1.252µs"
DEBUG[10-16|19:47:50.412] Served eth_unsubscribe                   reqid=10   duration="12.243µs"
INFO [10-16|19:47:50.412] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [10-16|19:47:50.412] State schema set to default              scheme=path
DEBUG[10-16|19:47:50.413] Served eth_subscribe                     reqid=283  duration="24.726µs"
TRACE[10-16|19:47:50.413] Handled RPC response                     reqid=283  duration="4.579µs"
DEBUG[10-16|19:47:50.413] Executing EVM call finished              runtime="248.353µs"
DEBUG[10-16|19:47:50.413] Served eth_call                          reqid=339  duration="306.252µs"
TRACE[10-16|19:47:50.413] Handled RPC response                     reqid=339  duration="2.294µs"
TRACE[10-16|19:47:50.412] Handled RPC response                     reqid=10   duration=742ns
DEBUG[10-16|19:47:50.413] Served eth_getCode                       reqid=377  duration="132.247µs"
--- FAIL: TestEthSyncing (24.12s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[pmikolajczyk41]

marking as draft because some tests are too slow with checking version for every message; will reopen once this is fixed

[ganeshvanahalli]

LGTM