fix: Return correct attnets over metadata reqresp when subscribed to all subnets #15827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a configuration flag, `flags.Get().SubscribeToAllSubnets`, to enable subscribing to all available attestation subnets instead of only those currently tracked in `cache.SubnetIDs.GetAllSubnets()`. This is useful for nodes that need to participate in all potential committees regardless of current committee assignments.
docs(changelog): add entry for fixing all subnets advertisement with flag
samcm
force-pushed
the
fix/attnets-metadata-all-subnets
branch
from
9ae52ca to
87fda4e
Compare
|
might not be the right approach we'll be looking into this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
We've added event capturing to all
Metadatareq/resp messages we recieve on mainnet, and have seen 0 Prysm nodes reporting they're on all subnets.Which issues(s) does this PR fix?
Fixes #15826
Other notes for review
Not sure if this is the best way to do it. I thought maybe we need to fix the underlying cache to return the correct subnets? But the pattern of checking if the flag is set seems to exist elsewhere in the codebase. Happy to do either.
Acknowledgements