Skip to content

fix: Return correct attnets over metadata reqresp when subscribed to all subnets #15827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Return correct attnets over metadata reqresp when subscribed to all subnets #15827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
199f81f
feat(p2p): allow subscribing to all attestation subnets
samcm Oct 9, 2025
87fda4e
feat(p2p): implement test for SubscribeToAllSubnets flag functionality
samcm Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions beacon-chain/p2p/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,16 @@ func (s *Service) RefreshPersistentSubnets() {

// Get the current attestation subnet bitfield.
bitV := bitfield.NewBitvector64()
attestationCommittees := cache.SubnetIDs.GetAllSubnets()
for _, idx := range attestationCommittees {
bitV.SetBitAt(idx, true)
if flags.Get().SubscribeToAllSubnets {
// Set all 64 bits for all attestation subnets
for i := uint64(0); i < params.BeaconConfig().AttestationSubnetCount; i++ {
bitV.SetBitAt(i, true)
}
} else {
attestationCommittees := cache.SubnetIDs.GetAllSubnets()
for _, idx := range attestationCommittees {
bitV.SetBitAt(idx, true)
}
}

// Get the attestation subnet bitfield we store in our record.
Expand Down
3 changes: 3 additions & 0 deletions changelog/samcm_fix-attnets-metadata-all-subnets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Fixed `--subscribe-all-subnets` flag to correctly advertise all 64 attestation subnets in reqresp metadata.