Enforce No Args Fallback Return Type#189
Open
rauljordan wants to merge 3 commits into
Open
Conversation
gligneul
approved these changes
Dec 23, 2024
Contributor
|
I think at some point would be better to manually verify the return type instead of relying on type inference of generated code. The error messages would probably be better as well. |
Contributor
Author
|
Agreed...I think I'll go ahead and do that before we merge |
Contributor
Author
|
Resolved with your feedback @gligneul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback func with no args should return Result<(), Vec>. It should not be possible to return Result<Vec, Vec>. Having an explicit match statement fixes the issue