Skip to content

Enforce No Args Fallback Return Type #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enforce No Args Fallback Return Type #189

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e95f771
enforce fallback no args return type
rauljordan Dec 23, 2024
5cd13fb
add in fallback signature check
rauljordan Mar 19, 2025
fc603d1
clippy
rauljordan Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions stylus-proc/src/macros/public/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,9 @@ impl<E: FnExtension> PublicFn<E> {
if matches!(self.kind, FnKind::FallbackNoArgs) {
return parse_quote! {
return Some({
if let Err(err) = Self::#name(#storage_arg) {
Err(err)
} else {
Ok(Vec::new())
match Self::#name(#storage_arg) {
Ok(()) => Ok(Vec::new()),
Err(err) => Err(err),
}
});
};
Expand Down
Loading