E2e fixes #249
Open
E2e fixes #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We are still not sure how we want to handle e2e tests, and I believe the current setup and folder structure will change a lot, so I would rather put this on hold until I have time to look into this further |
Author
|
Fair point, though it might beneficial to merge the current adjustments thats it is somewhat executable. But can be discarded as well. Merge or Close as you see fit. |
Collaborator
|
If you put it out of draft I'll merge in the meantime |
Collaborator
|
Also you need to fix merge conflicts |
Author
Which? I had none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Closes #246