Vamsi krishna created an interactive list of open issues by vamsikrishna1704 · Pull Request #1482 · OneCommunityGlobal/HGNRest

vamsikrishna1704 · 2025-06-21T19:27:58Z

Description

Related PRS (if any):

This backend PR is related to the #3683 frontend PR.
…

Main changes explained:

Controller handles fetching open issues with or without parameters(projectIds, tag, startDate, endDate)
Controller handles updating an issue contents like name or status.
Controller handles deleting an issue.
Router routes all the requests to respected controller functions.
…

How to test:

check into current branch
do npm install and npm run build to build and then npm start to run this PR locally
Clear site data/cache on browser
log as admin user
go to Dashboard→ Reports→ Total Construction Summary → Issue Tracking
Verify all the functionalities in both light and dark themes.

Screenshots or videos of changes:

Frontend Demo: (Light theme)

Dashboard.-.Vamsi.Krishna.Owner.-.Profile.1.-.Microsoft.Edge.2025-06-21.15-33-17.mp4

Frontend Demo:(Dark theme)
https://github.com/user-attachments/assets/6796d55c-c58f-4a1a-b427-327bc6f41325

Venk-rgb

Tested with Frontend PR #3683. Everything working as expected. Good job.

PR.3683.-.FE.mov

boppanapraveen

Checked with Frontend PR #3683, all looks good.

kedarnath1999

Logged in as admin, but I am getting 404

Deekshith010905 · 2025-07-07T19:52:10Z

Tested the Issue Tracking section under Dashboard → Reports → Total Construction Summary. The UI loaded correctly, but no issue data was displayed. A 404 error was shown when fetching open issues, indicating a missing or incorrect API endpoint. Filtering is not functional due to this error.

Juhitha-Reddy · 2025-07-08T21:18:21Z

Tested locally with corresponding frontend (#3683) and backend (#1482) branches.

Verified:
Page loads correctly with no console errors.
All functionalities behave as expected in both light and dark themes.
UI remains consistent and responsive across themes.

jaydeep138 · 2025-07-11T03:53:59Z

+    const controller = require('../../controllers/bmdashboard/bmIssueController')(buildingIssue);

-    IssueRouter.route('/issues')
+    IssueRouter.route('/issues/open')


The POST route is currently defined as /issue/add, while other routes use /issues/.... For consistency, consider renaming the POST endpoint to /issues (without /add). Alternatively, make all endpoints follow either the singular (/issue/...) or plural (/issues/...) naming pattern for consistency across your API routes. This will improve maintainability and clarity for consumers of the API.

jaydeep138 · 2025-07-11T03:57:07Z

+            } else if (startDate) {
+                query.createdDate = { $gte: new Date(startDate) };
+            } else if (endDate) {
+                query.createdDate = { $lte: new Date(new Date(endDate).setHours(23, 59, 59, 999)) };


Here, new Date(endDate) is constructed twice. You can refactor by creating the date object once, setting its hours, and then using it. For example:

const end = new Date(endDate); end.setHours(23, 59, 59, 999);

Then use end in your query.
This improves readability and performance by avoiding unnecessary object creation.

jaydeep138

Tested this in coordination with the frontend, and everything is working as expected from the UI side — filters, data updates, and overall functionality are all behaving correctly. Just implement the two minor suggested changes on the backend, and everything should be good to go.

shashank-madan

Changes work as expected. Tested with the corresponding frontend PR (Review comments)

harshavarma29

I have tested the backend separately in Postman using 'In-person' and 'Virtual' tags as params. It correctly returns only the associated issues for each tag.

However, in the frontend PR, when selecting the 'Virtual' tag, it displays an empty result instead of showing the associated issue for 'Virtual' tag.

Recording.2025-07-13.013516.mp4

saikrishnaraoyadagiri

Hi, Reviewed this PR, all filters are working as expected.

sankargalla

I verified backend PR #1482, and the APIs are fetching data as expected.

ManviKishore · 2025-07-20T03:10:18Z

Changes work as expected, tested through the Frontend branch.

harika-majji

Please check the frontend pr for detailed comments.

harika-majji

Added detailed comments in the frontend PR. Functionality works as expected, but there are a few frontend issues that need to be addressed.

…ist_of_open_issues

srushti2403

Checked with PR #3683, works well with light and dark mode.

MeronTeweldebrhan

PR Review Feedback

Testing Outcome

✅ Logged in as an admin user and navigated to Dashboard → Reports → Total Construction Summary → Issues Tracking.
✅ Verified functionalities in both light and dark modes; overall layout and pages appear fine.
⚠️ Some header text (e.g., Longest Open Issue inside the Issues Tracking dropdown and Planned vs. Actual Costs Tracking) has low contrast, making it hard to read.
❌ Data under A List of Issues fails to load, responding with error:
“Error fetching open issues with filters: AxiosError: Request failed with status code 404.”

laynet

Everything I tested I already wrote in PR #3683 OneCommunityGlobal/HighestGoodNetworkApp#3683 (review)
I've also included a screenshot of the console errors

akshith312

Provided Feedback on Related FE PR 3683

dunstanad · 2025-10-04T13:19:07Z

The code is not working as expected.
Error:
-Unable to fetch data (AxiosError) for projects in list of issues.

sanjeev29 · 2025-10-06T19:16:58Z

Reviewed this locally with the related frontend PR - 3683. Works as expected.

sumedhkumar96

Followed the instructions and tested the functionalities by running both frontend and backend locally. The changes work as expected. Screenshots and comments are provided in the frontend PR-3683

apoorvajainrp21 · 2025-10-20T01:10:41Z

The expected code is not working. I have provided a screenshot of the error in PR3683.

Vinay944924 · 2025-11-08T04:55:09Z

Hi Vamsi,
I have tested the PR locally and provided the detailed explanation in the frontend PR.

Sriamshreddy000 · 2025-11-11T00:33:56Z

Tested this PR locally along with the related frontend PR. Everything works as expected
Left detailed feedback and screenshots in the frontend PR for reference.

one-community · 2026-04-28T05:39:19Z

Redone with this PR: #2032

vamsikrishna1704 added 6 commits May 9, 2025 13:15

Added the endpoint to fetch the open issues

8267174

Function to fetch open issues added to controller

b0d5a88

Added the update & delete methods to building issues.

d044ca3

Added person property added to buildingIssue schema

2137789

Updated from the development branch

e98a60a

Filtering logic is added into the controller code

8df36ce

vamsikrishna1704 mentioned this pull request Jun 21, 2025

Vamsi krishna created an interactive list of open issues OneCommunityGlobal/HighestGoodNetworkApp#3683

Closed

vamsikrishna1704 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 21, 2025

Venk-rgb self-assigned this Jun 22, 2025

Venk-rgb approved these changes Jun 22, 2025

View reviewed changes

boppanapraveen approved these changes Jun 24, 2025

View reviewed changes

kedarnath1999 approved these changes Jun 26, 2025 •

edited

Loading

View reviewed changes

kedarnath1999 reviewed Jun 26, 2025

View reviewed changes

akshaygadsing approved these changes Jul 6, 2025

View reviewed changes

jaydeep138 reviewed Jul 11, 2025

View reviewed changes

shashank-madan approved these changes Jul 11, 2025

View reviewed changes

harshavarma29 reviewed Jul 13, 2025

View reviewed changes

saikrishnaraoyadagiri approved these changes Jul 14, 2025

View reviewed changes

sankargalla approved these changes Jul 18, 2025

View reviewed changes

ManviKishore approved these changes Jul 20, 2025

View reviewed changes

harika-majji suggested changes Jul 21, 2025

View reviewed changes

harika-majji approved these changes Jul 21, 2025

View reviewed changes

vamsikrishna1704 added 3 commits July 30, 2025 19:17

Renamed function name in issues controller.

0025155

Renamed function name in issues router.

b7cd5a2

Removed misplaced alphabet at the start of file.

1c4b5f6

vamsikrishna1704 added 6 commits August 1, 2025 17:03

Merge branch 'development' into Vamsi_Krishna_Create_an_interactive_l…

565f89f

…ist_of_open_issues

Update package-lock.json

1be335c

removed the multiple buildingIssue definitions.

bc6c693

Update package-lock.json

a76906c

Merge branch 'development' into Vamsi_Krishna_Create_an_interactive_l…

180b6f3

…ist_of_open_issues

Merge branch 'development' into Vamsi_Krishna_Create_an_interactive_l…

fd26eb9

…ist_of_open_issues

srushti2403 approved these changes Aug 27, 2025

View reviewed changes

MeronTeweldebrhan suggested changes Sep 23, 2025

View reviewed changes

laynet requested changes Sep 24, 2025

View reviewed changes

fix: bmGetIssueChart function modified.

a68e95a

vamsikrishna1704 requested review from MeronTeweldebrhan and laynet September 27, 2025 19:36

akshith312 reviewed Sep 30, 2025

View reviewed changes

sanjeev29 approved these changes Oct 6, 2025

View reviewed changes

sumedhkumar96 approved these changes Oct 17, 2025

View reviewed changes

one-community closed this Apr 28, 2026

Uh oh!

Conversation

vamsikrishna1704 commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

Uh oh!

Venk-rgb left a comment

Choose a reason for hiding this comment

Uh oh!

boppanapraveen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kedarnath1999 left a comment

Choose a reason for hiding this comment

Uh oh!

Deekshith010905 commented Jul 7, 2025

Uh oh!

Juhitha-Reddy commented Jul 8, 2025

Uh oh!

jaydeep138 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

jaydeep138 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

jaydeep138 left a comment

Choose a reason for hiding this comment

Uh oh!

shashank-madan left a comment

Choose a reason for hiding this comment

Uh oh!

harshavarma29 left a comment

Choose a reason for hiding this comment

Uh oh!

saikrishnaraoyadagiri left a comment

Choose a reason for hiding this comment

Uh oh!

sankargalla left a comment

Choose a reason for hiding this comment

Uh oh!

ManviKishore commented Jul 20, 2025

Uh oh!

harika-majji left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harika-majji left a comment

Choose a reason for hiding this comment

Uh oh!

srushti2403 left a comment

Choose a reason for hiding this comment

Uh oh!

MeronTeweldebrhan left a comment

Choose a reason for hiding this comment

Uh oh!

laynet left a comment

Choose a reason for hiding this comment

Uh oh!

akshith312 left a comment

Choose a reason for hiding this comment

Uh oh!

dunstanad commented Oct 4, 2025

Uh oh!

sanjeev29 commented Oct 6, 2025

Uh oh!

sumedhkumar96 left a comment

Choose a reason for hiding this comment

Uh oh!

apoorvajainrp21 commented Oct 20, 2025

Uh oh!

Vinay944924 commented Nov 8, 2025

Uh oh!

Sriamshreddy000 commented Nov 11, 2025

Uh oh!

one-community commented Apr 28, 2026

vamsikrishna1704 commented Jun 21, 2025 •

edited

Loading

harika-majji left a comment •

edited

Loading