Skip to content

Vamsi krishna created an interactive list of open issues#3683

Closed
vamsikrishna1704 wants to merge 23 commits into
developmentfrom
Vamsi_Krishna_Create_an_interactive_list_of_open_issues
Closed

Vamsi krishna created an interactive list of open issues#3683
vamsikrishna1704 wants to merge 23 commits into
developmentfrom
Vamsi_Krishna_Create_an_interactive_list_of_open_issues

Conversation

@vamsikrishna1704
Copy link
Copy Markdown
Contributor

@vamsikrishna1704 vamsikrishna1704 commented Jun 21, 2025

Description

image
image

Related PRS (if any):

To test this frontend PR you need to checkout the #1482 backend PR.

Main changes explained:

  • Date selection passes the selected date range to backend to filter and fetch issues during that date range.
  • Multi project selection passed the selected projects to backend to filter and fetch issues of those projects.
  • Tag button when clicked filters and fetches issues with that tag, clicked again to clear the filter.
  • Issues options are used to update issue name or status and delete an issue.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache on browser
  4. log as admin user
  5. go to Dashboard→ Reports→ Total Construction Summary→ Issues Tracking
  6. Verify all the functionalities in both light and dark mode.
  7. Follow the attached video for testing.

Screenshots or videos of changes:

Frontend Demo:(Light theme)

Dashboard.-.Vamsi.Krishna.Owner.-.Profile.1.-.Microsoft.Edge.2025-06-21.15-33-17.mp4

Frontend Demo:(Dark theme)

Total.Construction.Summary.-.Profile.1.-.Microsoft.Edge.2025-06-21.15-35-28.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 21, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit f6b2979
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/68d82831cd0c98000829224f
😎 Deploy Preview https://deploy-preview-3683--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vamsikrishna1704 vamsikrishna1704 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 21, 2025
@Venk-rgb Venk-rgb self-assigned this Jun 22, 2025
Venk-rgb
Venk-rgb previously approved these changes Jun 22, 2025
Copy link
Copy Markdown
Contributor

@Venk-rgb Venk-rgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Backend PR #1482. Everything works as expected. Good job!

PR.3683.-.FE.mov

boppanapraveen
boppanapraveen previously approved these changes Jun 24, 2025
Copy link
Copy Markdown
Contributor

@boppanapraveen boppanapraveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Frontend PR #1482 all looks good.
#3683

Copy link
Copy Markdown

@PrasanthBhimana PrasanthBhimana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the new Issue Tracking table implementation and it functions as expected. The table now supports advanced filtering by date range and multiple project selection, and clicking on tags correctly filters the issues. The “Options” dropdown in each row provides smooth interaction for renaming, deleting, or closing issues. The inline editing feature for issue names works well, and changes are reflected properly after multiple refreshes. The component displays consistently in both light and dark modes with no UI glitches. Overall, the update enhances usability and meets the functional requirements effectively. Approving the PR.

Screenshot 2025-06-27 at 6 47 32 PM Screenshot 2025-06-27 at 6 48 11 PM Screenshot 2025-06-27 at 6 48 40 PM

Saicharan1505
Saicharan1505 previously approved these changes Jun 28, 2025
Copy link
Copy Markdown

@Saicharan1505 Saicharan1505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR-3683:
Verified the interactive issue list with all required functionalities:

  • Tag filter toggle correctly filters and clears issues by tag

  • Date range and multi-project dropdowns fetch and display matching issues

  • "Options" dropdown works for rename, delete, and close actions

  • UI consistent across both dark and light modes

Everything looks good and matches the expected behavior as per the spec.

3683 #1
3683 #2
3683 #3

marcusyi1
marcusyi1 previously approved these changes Jul 6, 2025
Copy link
Copy Markdown
Contributor

@marcusyi1 marcusyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all functionality under Issue Tracking and on light mode and dark mode everything is working as expected.

PR3683.mov

@Juhitha-Reddy
Copy link
Copy Markdown
Contributor

Tested locally with corresponding frontend (#3683) and backend (OneCommunityGlobal/HGNRest#1482) branches.

Verified:
Page loads correctly with no console errors.
All functionalities behave as expected in both light and dark themes.
UI remains consistent and responsive across themes.
3683 + 1482 PR - 2
3683 + 1482 PR -1

uhakruthi1
uhakruthi1 previously approved these changes Jul 10, 2025
Copy link
Copy Markdown
Contributor

@uhakruthi1 uhakruthi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR-3683 and confirmed the interactive issue list functions correctly with tag filters, date range, multi-project dropdowns, and options for rename, delete, and close. The UI is consistent in both dark and light modes, meeting all specifications.
Screenshot 2025-07-10 at 5 58 28 PM
Screenshot 2025-07-10 at 5 59 04 PM
Screenshot 2025-07-10 at 5 59 12 PM
Screenshot 2025-07-10 at 5 59 40 PM

jaydeep138
jaydeep138 previously approved these changes Jul 11, 2025
Copy link
Copy Markdown
Contributor

@jaydeep138 jaydeep138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally — the Issue Tracking section is working as expected. The date filter, issue renaming, tag selection, and project filtering functionalities are all functioning correctly. Issues update appropriately based on the selected filters, and all related UI elements (tags, person, action menu) are displaying as intended. Everything looks good.
Screenshot 2025-07-11 at 00 12 32
Screenshot 2025-07-11 at 00 12 45
Screenshot 2025-07-11 at 00 13 33

shashank-madan
shashank-madan previously approved these changes Jul 11, 2025
Copy link
Copy Markdown
Contributor

@shashank-madan shashank-madan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main functionality changes are working as expected. The selected date range is correctly passed to the backend to filter and fetch issues within that range. Multi-project selection accurately filters issues by the selected projects. Clicking a tag button filters the issues by that tag, and clicking it again clears the filter, functioning as intended. Issue options allow for updating issue names and statuses, as well as deleting issues, all without errors.I verified all described functionalities in both light and dark mode. The implementation aligns with the behavior shown in the attached video. Everything looks good. Approving this PR

Total.Construction.Summary.-.Google.Chrome.2025-07-11.11-33-33.mp4
Total.Construction.Summary.-.Google.Chrome.2025-07-11.11-34-34.mp4

Copy link
Copy Markdown
Contributor

@harshavarma29 harshavarma29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the feature locally using admin credentials. It is working fine for most of the scenarios, but when I am selecting the 'virtual' tag, the complete row is getting removed. Please check the video below for reference.

Recording.2025-07-13.003436.mp4

Copy link
Copy Markdown
Contributor

@saikrishnaraoyadagiri saikrishnaraoyadagiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Reviewed this PR, all the filters are working as expected. but when we move to page 2 and apply a filter as shown in video reference and after applying filter we got results only sufficient for page 1, the results are in page 1 but as we applied filter in page 2 we are still staying in page 2 but as per the filter page is invalid now. To improve the user experience and ensure relevant data is displayed immediately, we should automatically reset the pagination to page 1, if there are no enough results to display in the filter applied page.

saikrishna.PR.3683+1482.mp4

sankargalla
sankargalla previously approved these changes Jul 18, 2025
Copy link
Copy Markdown
Contributor

@sankargalla sankargalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified Frontend PR #3683 in both light and dark modes, and all the functional and UI requirements are working as expected.

PR 3683(1) PR 3683(2)

karnati007
karnati007 previously approved these changes Aug 21, 2025
Copy link
Copy Markdown
Contributor

@karnati007 karnati007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vamsikrishna1704, As the changes in the code resolved merge conflicts by keeping the functionalities working as expected. I am satisfied to approve the PR. Thank you.
image

Copy link
Copy Markdown
Contributor

@MeronTeweldebrhan MeronTeweldebrhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Feedback

Testing Outcome

✅ Logged in as an admin user and navigated to Dashboard → Reports → Total Construction Summary → Issues Tracking.
✅ Verified functionalities in both light and dark modes; overall layout and pages appear fine.
⚠️ Some header text (e.g., Longest Open Issue inside the Issues Tracking dropdown and Planned vs. Actual Costs Tracking) has low contrast, making it hard to read.
❌ Data under A List of Issues fails to load, responding with error:
“Error fetching open issues with filters: AxiosError: Request failed with status code 404.”

Screenshot 2025-09-23 190925 Screenshot 2025-09-23 190959 Screenshot 2025-09-23 191022

Copy link
Copy Markdown

@laynet laynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the testing instructions and logged in as admin. When I was asked to sign in again after navigating to “total construction summary” it didn’t reroute me after i logged in, but I was able to get to the page by using the dropdown again.
Upon opening the “Issues tracking” dropdown I immediately had an error. The error persisted after reset and after choosing a date range. Error persisted after a hard refresh. I cleared data, logged out and back in as admin, error persisted.
PR 3683 404 error
PR 3683 after reset
The reset button did work after I selected dates, but the error never went away and I was never able to test anything/no data was ever displayed. Dark mode behaved the same.

@vamsikrishna1704
Copy link
Copy Markdown
Contributor Author

I followed the testing instructions and logged in as admin. When I was asked to sign in again after navigating to “total construction summary” it didn’t reroute me after i logged in, but I was able to get to the page by using the dropdown again. Upon opening the “Issues tracking” dropdown I immediately had an error. The error persisted after reset and after choosing a date range. Error persisted after a hard refresh. I cleared data, logged out and back in as admin, error persisted. PR 3683 404 error PR 3683 after reset The reset button did work after I selected dates, but the error never went away and I was never able to test anything/no data was ever displayed. Dark mode behaved the same.

Hi @laynet, based on the error that you posted, it seems that you have not checked in the HGNRest to my branch. Try checking into Vamsi_Krishna_Create_an_interactive_list_of_open_issues and verify the fetures and functionalities. Thank you.

@vamsikrishna1704
Copy link
Copy Markdown
Contributor Author

PR Review Feedback

Testing Outcome

✅ Logged in as an admin user and navigated to Dashboard → Reports → Total Construction Summary → Issues Tracking. ✅ Verified functionalities in both light and dark modes; overall layout and pages appear fine. ⚠️ Some header text (e.g., Longest Open Issue inside the Issues Tracking dropdown and Planned vs. Actual Costs Tracking) has low contrast, making it hard to read. ❌ Data under A List of Issues fails to load, responding with error: “Error fetching open issues with filters: AxiosError: Request failed with status code 404.”

Screenshot 2025-09-23 190925 Screenshot 2025-09-23 190959 Screenshot 2025-09-23 191022

Hi @MeronTeweldebrhan, you are checking the 'Longest open issues' which is not my task. You have to check the 'List of Issues table' which is the one I worked on. Also you have to check into my branch in HGNRest to see the issues data. Try the suggested steps and verify the features and functionalities of the task.

Copy link
Copy Markdown
Contributor

@akshith312 akshith312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR locally and logged in as Admin.
Checked the Issues Tracking Part.

The Filters and Buttons work well in both Light and Dark Modes. Only Issue is that the table is generating rows for date ranges where there is no data.
image

Table displaying Empty rows with Untitled in Issue Name Column.
image

image image

@dunstanad
Copy link
Copy Markdown

The code is not working as expected.
Error:
-Unable to fetch data (AxiosError) for projects in list of issues.
error

@sanjeev29
Copy link
Copy Markdown
Contributor

Tested the PR locally on the Chrome browser.

The filters work as expected. One issue is there are issues without a title and it doesn't hold any value when displayed in the table.
PR-3683

Copy link
Copy Markdown
Contributor

@sumedhkumar96 sumedhkumar96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes made by the dev by running the frontend and the backend code locally. All the features listed are implemented and it works as expected in both light and dark modes. But there is a section which is on the right side of "List of Issues" called the "Longest Open Issues", that part needs work but I think those changes were made by a different dev which needs a fix.

Screenshot 2025-10-17 002629

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible High Priority labels Oct 18, 2025
@apoorvajainrp21
Copy link
Copy Markdown
Contributor

Error loading projects: : Tested for PR1482 + PR 3683
Screenshot 2025-10-17 113051

@Vinay944924
Copy link
Copy Markdown
Contributor

Hi Vamsi,
I tested the PR locally and I am getting error like AxiosError and failed with status code 404. Can you please verify this

Screenshot 2025-11-04 at 7 10 46 PM

@Sriamshreddy000
Copy link
Copy Markdown
Contributor

Hi Vamshi,

I tested this PR along with the related backend PR while logged in as an admin user. In the Issues Tracking section, the table functions correctly in both light and dark modes. The "Longest Open Issues" UI seems like it might need a bit of rework, though I assume that’s being handled in a separate PR by a separate dev.

Attaching screenshot for reference
Screenshot 2025-11-10 at 4 11 12 PM

@one-community
Copy link
Copy Markdown
Member

Redone with this PR: #4800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.