-
Notifications
You must be signed in to change notification settings - Fork 8
Add handling for now included GDB redistributable #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
|
Not yet ready for review:
|
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will increase coverage by 1.99%. File Coverage Changes
🛟 Help
|
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
|
For testing:
|
|
Will not work OOB on MacOS. Packaging just zipped in the entire tarball. Needs another iteration on the download script. |
|
Yep, just got the ENOENT massage. |
|
Tested the Mac installer on M3. |
|
All Unix builds are busted. The only one containing the extracted distribution is the Windows one. |
|
Windows seems to work. If I open a new terminal and try to launch gdb from the command line I get: |
Signed-off-by: Jens Reinecke <[email protected]>
c035ecf to
3c82dc5
Compare
… and xz, leave in 'file-type' for later refinement Signed-off-by: Jens Reinecke <[email protected]>
|
CI should be fixed now. Apologies for the notification spam, but it took a while until I understood how I can dig into this on my local Windows machine. And became desperate along the way and tried a lot of, in hindsight, useless things. Two relevant changes:
I suspect a lot of the issues didn't show while initially developing and fixing the download scripts because of heavy caching actions in our CI. The Note: Quite handy to know you can clean such caches from the GitHub GUI. But only found this late in the investigation. |
|
@thorstendb-ARM , @KeilChris , would you mind giving the intended OOB-experience another try on Monday? |
|
Forgot, new VSIX files for testing are here: https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/actions/runs/16225620619 |
jkrech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the local artifact:
VSCode CMSIS Debugger 0.4.1-pr388-g4e26b09.0
on macOS Apple M1 Pro - Sequoia 15.5
a) arm-none-eabi-gdb
GNU gdb (Arm GNU Toolchain 14.3.Rel1 (Build arm-14.174)) 15.2.90.20241229-git
b) successfully extracted in
~/.vscode/extensions/arm.vscode-cmsis-debugger-0.4.1-pr388-g4e26b09.0/tools/gdb/bin/arm-none-eabi-gdb
c) I am seeing in the VSCode terminal that the gdb is added to the path twice:
where arm-none-eabi-gdb
/Users/jkrech/.vscode/extensions/arm.vscode-cmsis-debugger-0.4.1-pr388-g4e26b09.0/tools/gdb/bin/arm-none-eabi-gdb
/Users/jkrech/.vscode/extensions/arm.vscode-cmsis-debugger-0.4.1-pr388-g4e26b09.0/tools/gdb/bin/arm-none-eabi-gdb
|
Tested on Windows - works as expected. Path is only added once |
|
Thanks for testing the latest VSIX. @thorstendb-ARM , can you please check on Mac if you see the same as @jkrech ? |
|
Works for me as well. I had to reboot the machine to make it work, but now everything's OK. |
|
I am going to merge now that I got confirmation for Windows and Mac. Follow-up actions:
|
Fixes
Changes
prependoperations overwrite each other.Other
allscript to build, download tools, and run test in one go. Forgot one time too many to download the tools and being surprised by things failing.customResetCommandsto some types (not really used).Screenshots
Checklist