-
Notifications
You must be signed in to change notification settings - Fork 8
Add complex data type support to live watch #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Diff Coverage: The code coverage on the diff in this pull request is 93.5%. Total Coverage: This PR will increase coverage by 0.13%. File Coverage Changes
🛟 Help
|
IIUC, you only need a single monochrome SVG icon for view containers. Coloring should be adjusted by VS Code automatically. |
My bad, dark vs light theme is only used for command icons/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the swift response to my feedback! Functionality works nicely!
One minor note for a later increment: you can expand node children while the CPU is running. But no new children appear. I think in theory you should be able to fetch the children if things are running. But I see this as a minor defect that can be addressed in a separate PR. Please make a note of it, I think view discoverability and context menu are the next things to look into.
Fixes
Changes
P.S. So far I don't know how to customise the view container icon depending on VSCode's theme. However, I added the two icons provided by @KeilChris in the repo until I find a way
Screenshots
Checklist