Skip to content

Add complex data type support to live watch #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 27, 2025
Merged

Add complex data type support to live watch #592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cc5d0a4
add support for complex data types
omarArm Oct 24, 2025
83fc814
Changing tests in accordance with new data model for live watch, addi…
omarArm Oct 27, 2025
0f01d12
updating icon file
omarArm Oct 27, 2025
2ae4c88
updating tests of gdbtarget-debug-session to accommodate changes in s…
omarArm Oct 27, 2025
4dfe2c2
making use of the global mocks file
omarArm Oct 27, 2025
428fbb9
adding icon to view window
omarArm Oct 27, 2025
72a72fb
refactoring and taking reviews into consideration
omarArm Oct 27, 2025
b0606d6
adding a couple more tests and changing location of icons
omarArm Oct 27, 2025
00702ee
updating command names
omarArm Oct 27, 2025
c89dbaf
updating command names for better scoping
omarArm Oct 27, 2025
ddadf1c
updating command names in tests
omarArm Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions __mocks__/vscode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ const MockTreeItemCollapsibleState = {
Expanded: 2
};

const registerTreeDataProviderMock = jest.fn(() => ({ dispose: jest.fn() }));

class MockTreeItem {
label;
description;
Expand Down Expand Up @@ -71,6 +73,7 @@ module.exports = {
warn: jest.fn(),
error: jest.fn(),
})),
registerTreeDataProvider: registerTreeDataProviderMock,
showWarningMessage: jest.fn(),
createStatusBarItem: jest.fn(),
showQuickPick: jest.fn(),
Expand Down
9 changes: 1 addition & 8 deletions src/views/live-watch/live-watch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import { GDBTargetDebugSession, GDBTargetDebugTracker } from '../../debug-sessio
import { gdbTargetConfiguration } from '../../debug-configuration/debug-configuration.factory';
import { GDBTargetConfiguration } from '../../debug-configuration';

// Inline mock for registerTreeDataProvider specific to these tests
const registerTreeDataProviderMock = jest.fn(() => ({ dispose: jest.fn() }));

describe('LiveWatchTreeDataProvider', () => {
let liveWatchTreeDataProvider: LiveWatchTreeDataProvider;
Expand All @@ -50,19 +48,15 @@ describe('LiveWatchTreeDataProvider', () => {

describe('session management and connection tests', () => {
it('should activate the live watch tree data provider', () => {
(vscode.window).registerTreeDataProvider = registerTreeDataProviderMock;
liveWatchTreeDataProvider.activate(tracker);
});

it('registers the live watch tree data provider', async () => {
(vscode.window).registerTreeDataProvider = registerTreeDataProviderMock;
registerTreeDataProviderMock.mockClear();
liveWatchTreeDataProvider.activate(tracker);
expect(registerTreeDataProviderMock).toHaveBeenCalledWith('cmsis-debugger.liveWatch', liveWatchTreeDataProvider);
expect(vscode.window.registerTreeDataProvider).toHaveBeenCalledWith('cmsis-debugger.liveWatch', liveWatchTreeDataProvider);
});

it('manages session lifecycles correctly', async () => {
(vscode.window).registerTreeDataProvider = registerTreeDataProviderMock;
liveWatchTreeDataProvider.activate(tracker);
// No active session yet
expect((liveWatchTreeDataProvider as any).activeSession).toBeUndefined();
Expand Down Expand Up @@ -221,7 +215,6 @@ describe('LiveWatchTreeDataProvider', () => {
describe('command registration', () => {
beforeEach(() => {
(vscode.commands as any).registerCommand?.mockClear?.();
(vscode.window as any).registerTreeDataProvider = registerTreeDataProviderMock;
});

function getRegisteredHandler(commandId: string) {
Expand Down