-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Add workflow to test Elixir clients #21214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@efcasado can you please review the test failure when you've time? I think we may need to update the tests after merging some of your PRs (e.g. update dependencies to newer versions) |
I'll do! I wasn't aware the generator was generating any tests (didn't bother checking either 😓). At first glance, it seems the issue was introduced by #21039 which is when Jason was retired in favor of the built-in JSON module. Do you want me to create a separate branch for the fixes, or do you want me to contribute directly to this pull request? |
directly to this branch please |
I cannot push to this branch directly, I will have to do the changes in my fork an open a pull request towards this branch (maybe this is what you meant, just want to be clear about expectations). Either way, a fix will be available soon 🙏 |
* update tests to use built-in json module instead of jason * update base_url * temporarily disable type-casting for dates * retry failing tests
@efcasado fyi. i updated the spec to use localhost and start a petstore server locally. all elixir tests passed. thanks for updating the tests to make all the tests passed |
FYI @mrmstn (2018/12)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)