Skip to content

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Sep 2, 2025

When called without a specific locale, String.format() will use the system default locale which doesn't make sense with English messages in our Mustache templates.

This will also cause warnings/failures when using static analysis tools such as Forbidden API Checker:

Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]
  in com.example.model.MyModelDeserializer (MyModelDeserializer.java:145)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

@joschi joschi force-pushed the java-string-format-locale-root branch from cf1637f to 33318aa Compare September 2, 2025 14:41
@joschi joschi force-pushed the java-string-format-locale-root branch from 33318aa to f8baa64 Compare September 2, 2025 15:47
@joschi joschi force-pushed the java-string-format-locale-root branch from f8baa64 to d42fbe1 Compare September 2, 2025 16:15
@wing328 wing328 added this to the 7.16.0 milestone Sep 3, 2025
@wing328 wing328 merged commit babb3e2 into OpenAPITools:master Sep 3, 2025
102 checks passed
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
…s#21871)

* [Java] Add missing Locale to String.format() invocations

* chore: ./bin/generate-samples.sh ./bin/configs/*.yaml
@Chrimle
Copy link
Contributor

Chrimle commented Nov 9, 2025

Correct me if I am wrong, but the Locale is only needed for the {{#supportUrlQuery}}-block, but every single model now have import java.util.Locale;.

Could there potentially be a {{#supportUrlQuery}}-block around the import-statement as well?

Created #22313

@joschi
Copy link
Contributor Author

joschi commented Nov 10, 2025

@Chrimle Maybe you could provide a PR for that. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants