Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 26, 2016

No description provided.

@mheden
Copy link
Collaborator

mheden commented Aug 26, 2016

CLA received.

@mheden
Copy link
Collaborator

mheden commented Sep 9, 2016

Sorry for the delay, I'll look over this as soon as my schedule permits.

#include "ethercatmain.h"
#include "ethercatfoe.h"

#define EC_MAXFOEDATA 512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep EC_MAXFOEDATA and set it to EC_MAXMBX

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll commit the change in ethercatfoe with my comment, the changes in firmware we'll leave out.

@gralpli
Copy link

gralpli commented May 2, 2020

This pull request solves a problem for me! Why hasn’t this been accepted yet?

firm_update.c from the master branch always failed with status code -3. Wireshark revealed that the FoE response from the slave contained gibberish. (aFOEp->MbxHeader.mbxtype & 0x0f) evaluated to 0x0a.

I will investigate further what the actual problem was and why this pull request solved it.

@nakarlsson
Copy link
Contributor

Some minor updates of the PR for FoE, and I think the update of fimrware update should be handled in a seperate PR. Perhaps you can finish the started work?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sebastian Block seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants