-
Notifications
You must be signed in to change notification settings - Fork 815
some improvement on FoE (large mailboxes, busy answer, firmware_update) #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ve have large mailbox in bootstrap)
… for slaves which update in BOOT2INIT transition
|
CLA received. |
|
Sorry for the delay, I'll look over this as soon as my schedule permits. |
| #include "ethercatmain.h" | ||
| #include "ethercatfoe.h" | ||
|
|
||
| #define EC_MAXFOEDATA 512 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep EC_MAXFOEDATA and set it to EC_MAXMBX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll commit the change in ethercatfoe with my comment, the changes in firmware we'll leave out.
|
This pull request solves a problem for me! Why hasn’t this been accepted yet?
I will investigate further what the actual problem was and why this pull request solved it. |
|
Some minor updates of the PR for FoE, and I think the update of fimrware update should be handled in a seperate PR. Perhaps you can finish the started work? |
|
Sebastian Block seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
No description provided.