fix: add SumsOf2 fallback for Highway < 1.1.0#669
Closed
KimYannn wants to merge 1 commit into
Closed
Conversation
SumsOf2 (pairwise widen-and-add) was introduced in Highway 1.1.0 but some distro packages ship older versions. Add a compile-time fallback that implements the same semantics via store/scalar-add/load, gated on HWY_MAJOR/HWY_MINOR. On Highway >= 1.1.0 the native op is used with zero overhead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #670 which includes this fix plus additional optimizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SumsOf2when building against Highway < 1.1.0hn::SumsOf2with zero overheadTest plan
simd.ocompiles cleanly with Highway 1.3.0 (native path)testSimd()to confirm correctness on both paths🤖 Generated with Claude Code