Fix writer drain deadlock#696
Open
KimYannn wants to merge 3 commits into
Open
Conversation
Ensure writer threads keep scanning all output queues until every producer is finished and every queue is empty, preventing hangs and premature exit when some worker queues are empty. 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land>
Cover high-thread writer queue cases where some worker output queues finish empty while others still need draining. 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land>
Write worker output queues in original pack order so repeated multi-threaded runs produce stable decompressed FASTQ content, and cover the behavior with an MD5 regression test. 💘 Generated with Crush Co-Authored-By: Crush <crush@charm.land>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
make -j$(sysctl -n hw.ncpu)./fastp test./fastp --version && ./fastp -i testdata/R1.fq -o /dev/nullbash scripts/test_writer_no_hang.shFixes #695
💘 Generated with Crush