fix: Remove pydantic.v1 warning for Python 3.14 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running in Python 3.14, importing pydantic.v1 produces a warning message. The code was porting it specifically for a Python 3.9 compatibility issue, so this change is to only do that import in Python 3.9 and for 3.10+ only use the newer pydantic. Added Python versions 3.13 and 3.14 to the github action test matrix Signed-off-by: Mark <[email protected]>
|
epmog
approved these changes
Oct 27, 2025
AWS-Samuel
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When running in Python 3.14, importing pydantic.v1 produces a warning message. The code was porting it specifically for a Python 3.9 compatibility issue.
What was the solution? (How)
This change is to only do that import in Python 3.9 and for 3.10+ only use the newer pydantic.
What is the impact of this change?
Remove the warning message when using Python 3.14.
How was this change tested?
Added Python versions 3.13 and 3.14 to the github action test matrix
Was this change documented?
No
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.