Create java.lang and java.math imposter classes for use in testing qualified names. #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lang package. Signed-off-by: Michael Glavassevich <[email protected]>
…math package. Signed-off-by: Michael Glavassevich <[email protected]>
… types. Signed-off-by: Michael Glavassevich <[email protected]>
Signed-off-by: Michael Glavassevich <[email protected]>
mrglavas
requested review from
TrevCraw,
aparnamichael,
dessina-devasia and
turkeylurkey
dessina-devasia
approved these changes
Nov 7, 2024
Contributor
dessina-devasia
left a comment
dessina-devasia
left a comment
There was a problem hiding this comment.
Looks good to me
turkeylurkey
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1080
Package mappings:
I explicitly chose these package names because they are suffixes of the Java built-in packages. Code which incorrectly matches qualified names using the
String.endsWith()method can potentially be identified by using these imposter classes in the test application.