Shared suites for Maven/Gradle Tests#609
Merged
sharma1208 merged 5 commits intoJun 29, 2026
Merged
Conversation
mattbsox
previously approved these changes
Jun 24, 2026
- Created shared/restSnippetSuite.ts for REST snippet tests - Created shared/hoverTestSuite.ts for hover tests - Created shared/devModeTestSuite.ts for DevMode tests (6 shared tests) - Refactored Maven/Gradle entry files to use shared suites - Achieved ~50% code reduction through parameterization - Kept build-tool-specific tests in separate describe blocks
1f2e2a4 to
6476623
Compare
Contributor
Author
|
force rebase due to changes on POM refactoring moving methods to editorUtils.ts #606 |
…r due to LSP4Jakarta issues
mattbsox
reviewed
Jun 26, 2026
mattbsox
left a comment
Member
There was a problem hiding this comment.
Looks good, but I think we'll need to refactor the Gradle 9 test too.
mattbsox
requested changes
Jun 26, 2026
mattbsox
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #606
Fixes #607
Summary
After the POM refactor (#606), Maven and Gradle test files were nearly identical except for build-tool-specific data (project paths, parameter formats, report locations). This PR collapses each test pair into shared parameterized suites, eliminating ~50% of test code duplication.
Changes
Created 3 Shared Test Suites (
src/test/shared/)restSnippetSuite.ts{ buildTool, getProjectPath }hoverTestSuite.ts{ buildTool, getProjectPath, hoverTestCases }devModeTestSuite.ts{ buildTool, getProjectPath, projectConstant, testRunString }Refactored Entry Files
Each Maven/Gradle entry file now: