Skip to content

Conversation

@volosied
Copy link
Member

@volosied volosied commented Dec 22, 2025

################################################################################################

tcpReadCtx.getBuffer() doesn't look to be used in netty, for example:
https://github.com/OpenLiberty/open-liberty/blob/d091431a6cc980bb4ab9f5a0bf82201b78454a75/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/Connection.java#L405C1-L407C18

NettyConnectionReadCompletedCallback.readCompleted() uses buffers from the netty pipeline.

Fixes #31349

@volosied volosied marked this pull request as draft December 22, 2025 16:45
@volosied volosied self-assigned this Dec 22, 2025
@volosied
Copy link
Member Author

volosied commented Dec 22, 2025

#build #spawn.fullfat.buckets=com.ibm.ws.jbatch.jms.joblog_fat,com.ibm.ws.jbatch.jms.single_fat,com.ibm.ws.jbatch.jms.throttle_fat,com.ibm.ws.jbatch.jms2_fat,com.ibm.ws.jbatch.jms3_fat,com.ibm.ws.jbatch.jms4_fat,com.ibm.ws.jbatch.jms5_fat,com.ibm.ws.jbatch.jms6_fat,com.ibm.ws.jbatch.jms_fat,com.ibm.ws.jca.resourcedefinition.jms.2.0_fat,com.ibm.ws.jca_fat_jms.thirdparty,com.ibm.ws.messaging.jms.wmq_fat,com.ibm.ws.messaging.jms.wmq_zfat,com.ibm.ws.messaging.jms20.wmq_fat_java7,com.ibm.ws.messaging.jms20AutoCloseable_fat_java7,com.ibm.ws.messaging.jms_fat,com.ibm.ws.ejbcontainer.mdb.jms_fat,com.ibm.ws.jca_fat_bvt.jms,com.ibm.ws.messaging.open_jms20AutoCloseable_fat,com.ibm.ws.messaging.open_jms20_fat,com.ibm.ws.messaging.open_jms20contextSecurity2_fat,com.ibm.ws.messaging.open_jms20contextSecurity_fat,com.ibm.ws.messaging.open_jms20context_fat,com.ibm.ws.messaging.open_jms20deliverydelay_fat,com.ibm.ws.messaging.open_jms20security_fat,io.openliberty.checkpoint_fat_jms (view Open Liberty Personal Build - ⚠️ completed with warnings.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Netty: JMS: Address TODO in Connection.java

2 participants