Skip to content

[DRAFT] Initialize buffer only for CHFW #33724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
volosied wants to merge 1 commit into
base: integration
Choose a base branch
from
Draft

[DRAFT] Initialize buffer only for CHFW #33724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/Connection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2012, 2023 IBM Corporation and others.
* Copyright (c) 2012, 2025 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -373,8 +373,8 @@ protected ConversationImpl startNewConversationGeneric(ConversationImpl conv, bo
}

// MS:4 take advantage of being able to leave this null for read (cf integration)
// TODO: Verify adding Netty check for performance?
if (tcpReadCtx.getBuffer() == null)
// Only needed for CHFW
if (!isUsingNetty() && tcpReadCtx.getBuffer() == null)
{
if (TraceComponent.isAnyTracingEnabled() && tc.isDebugEnabled()) SibTr.debug(this, tc, "needs new buffer");
WsByteBuffer buffer = WsByteBufferPool.getInstance().wrap(new byte[1024]); // F196678.10
Expand Down