Skip to content

locale: cleanup en_US translation CSV files#5528

Draft
Copilot wants to merge 4 commits into
mainfrom
copilot/cleanup-translation-csv
Draft

locale: cleanup en_US translation CSV files#5528
Copilot wants to merge 4 commits into
mainfrom
copilot/cleanup-translation-csv

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

The openmage/dev-translations tool identified 437 obsolete strings still present in translation CSVs and 309 strings used in source code that were missing from CSVs.

Removals (437 strings across 35 files)

  • Mage_GoogleCheckout.csv — stripped ~99 strings for the deprecated module (kept the deprecation notice itself)
  • Mage_Adminhtml.csv — removed 109 strings for removed features (polls, backups UI, Google Base/Content, FTP, legacy card types)
  • Mage_Install.csv — removed Magento-branded strings replaced by OpenMage equivalents
  • Mage_Paypal.csv, Mage_Eav.csv, Mage_Rule.csv — removed strings for non-existent code paths

Additions (296 strings across 39 files)

  • Mage_Usa.csv (+167) — USPS REST API v2 and UPS REST carrier strings (service names, OAuth config labels, label generation, address verification)
  • Mage_Core.csv (+28) — widget labels, rate limiting config, admin theme settings, jQuery settings
  • Mage_Adminhtml.csv (+21) — OpenMage branding strings, CSP host field, orphaned resources, new config source labels
  • Mage_Install.csv (+6) — OpenMage-branded replacements for removed Magento strings

New files

  • Mage_Admin.csv — password validation errors, orphaned ACL resource notice
  • Mage_Csp.csv — 18 strings for the CSP module system config (default-src, script-src, report URI, etc.)

Fix

Corrected a pre-existing malformed CSV entry in Mage_Catalog.csv where \" (non-standard backslash escaping) was used instead of the CSV-standard "" doubling for the Attribute group with the "/name/" name already exists key.

Copilot AI linked an issue Apr 23, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Cleanup translation.csv by adding and removing entries locale: cleanup en_US translation CSV files Apr 23, 2026
Copilot AI requested a review from sreichel April 23, 2026 20:20
@github-actions github-actions Bot added the translations Relates to app/locale label Apr 23, 2026
@sreichel sreichel marked this pull request as ready for review April 23, 2026 20:27
Copilot AI review requested due to automatic review settings April 23, 2026 20:27
@sreichel
Copy link
Copy Markdown
Contributor

Mage_Install.csv — removed Magento-branded strings replaced by OpenMage equivalents

Nice :)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates OpenMage’s en_US locale CSVs to align translations with current code usage by removing obsolete keys, adding missing keys, and introducing new translation files for newly split/added functionality (e.g., CSP, admin-specific messages).

Changes:

  • Removed large sets of obsolete translation keys from many module CSVs.
  • Added missing translation keys across modules (notably shipping/USPS/UPS, core/admin configuration labels).
  • Added new translation files: Mage_Admin.csv and Mage_Csp.csv.

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
app/locale/en_US/Mage_Wishlist.csv Add/remove wishlist-related UI strings.
app/locale/en_US/Mage_Weee.csv Remove unused WEEE display strings.
app/locale/en_US/Mage_Usa.csv Major addition of USPS/UPS REST + config/help strings.
app/locale/en_US/Mage_Tax.csv Remove obsolete tax-rule UI strings.
app/locale/en_US/Mage_SalesRule.csv Add missing sales rule condition/operator strings.
app/locale/en_US/Mage_Sales.csv Add/remove sales/admin UI strings and payment/IPN text.
app/locale/en_US/Mage_Rule.csv Remove obsolete rule operator fragments.
app/locale/en_US/Mage_Review.csv Remove unused review template string.
app/locale/en_US/Mage_Reports.csv Add missing reports config label(s).
app/locale/en_US/Mage_Rating.csv Remove unused rating strings.
app/locale/en_US/Mage_PaypalUk.csv Add missing PayPal UK module messages.
app/locale/en_US/Mage_Paypal.csv Remove obsolete PayPal strings.
app/locale/en_US/Mage_Payment.csv Remove obsolete CC label strings; add new status-unassign error text.
app/locale/en_US/Mage_Paygate.csv Remove obsolete gateway label; add missing progress label.
app/locale/en_US/Mage_Page.csv Remove obsolete demo/marketing strings; adjust branding text.
app/locale/en_US/Mage_Oauth.csv Fix/update OAuth validation strings and placeholders.
app/locale/en_US/Mage_Newsletter.csv Remove obsolete strings; add new validation/error messages.
app/locale/en_US/Mage_Log.csv Remove obsolete log label; add missing selector label.
app/locale/en_US/Mage_Install.csv Remove old Magento-branded installer strings; add OpenMage equivalents.
app/locale/en_US/Mage_ImportExport.csv Remove unused import/export validation string.
app/locale/en_US/Mage_GoogleCheckout.csv Strip deprecated GoogleCheckout strings; keep deprecation notice.
app/locale/en_US/Mage_GoogleAnalytics.csv Update analytics strings for GA4/GTM.
app/locale/en_US/Mage_Eav.csv Remove unused validator messages; keep active ones.
app/locale/en_US/Mage_Directory.csv Update directory/currency provider labels and help text.
app/locale/en_US/Mage_Dataflow.csv Remove malformed/duplicate entry.
app/locale/en_US/Mage_Customer.csv Remove unused validator strings; add missing customer/admin labels and VAT prompts.
app/locale/en_US/Mage_CurrencySymbol.csv Add missing “Manage Currency Symbols” label.
app/locale/en_US/Mage_Csp.csv New CSP module config directive/label strings.
app/locale/en_US/Mage_Cron.csv Remove unused minute interval labels; keep core cron config strings.
app/locale/en_US/Mage_Core.csv Add missing core/admin settings labels and security/path messages; remove obsolete duplicates.
app/locale/en_US/Mage_Contacts.csv Move/normalize warning text entry formatting.
app/locale/en_US/Mage_Cms.csv Add missing CMS/admin page/config labels; remove unused ones.
app/locale/en_US/Mage_Checkout.csv Remove obsolete checkout UI strings and HTML-encoded duplicate.
app/locale/en_US/Mage_CatalogSearch.csv Replace obsolete string with missing config label.
app/locale/en_US/Mage_CatalogRule.csv Remove obsolete rule-apply warning text.
app/locale/en_US/Mage_CatalogInventory.csv Add missing qty-increment and admin labels/messages.
app/locale/en_US/Mage_Catalog.csv Add missing catalog/admin config labels; fix malformed CSV escaping; adjust printf placeholders.
app/locale/en_US/Mage_Authorizenet.csv Remove strings for deprecated/removed Authorize.Net paths.
app/locale/en_US/Mage_Adminhtml.csv Add missing admin UI/config/error strings; remove strings for removed features (polls/backups UI/etc.).
app/locale/en_US/Mage_AdminNotification.csv Remove unused feed HTTPS label.
app/locale/en_US/Mage_Admin.csv New admin-specific password/ACL-orphan messages.

Comment thread app/locale/en_US/Mage_Payment.csv Outdated
Comment thread app/locale/en_US/Mage_Oauth.csv Outdated
Comment thread app/locale/en_US/Mage_Usa.csv Outdated
Comment thread app/locale/en_US/Mage_Adminhtml.csv Outdated
Comment thread app/locale/en_US/Mage_Adminhtml.csv Outdated
Comment thread app/locale/en_US/Mage_Adminhtml.csv Outdated
Comment thread app/locale/en_US/Mage_PaypalUk.csv Outdated
Comment thread app/locale/en_US/Mage_Customer.csv Outdated
Comment thread app/locale/en_US/Mage_Newsletter.csv Outdated
Comment thread app/locale/en_US/Mage_Usa.csv Outdated
@sreichel
Copy link
Copy Markdown
Contributor

@copilot fix grammatical mistake only in 2nd column

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 23, 2026

@copilot fix grammatical mistake only in 2nd column

Fixed in ba3e42a. All 10 grammatical issues corrected in the 2nd column (translation values) only, keys left unchanged:

  • Mage_Payment.csv: "It is in used in" → "It is in use in"
  • Mage_Oauth.csv: "must has length %max%" → "must have a maximum length of %max%"; "must has length %min%" → "must have a minimum length of %min%"
  • Mage_Adminhtml.csv: "successfuly" → "successfully"; "at least of %d characters" → "at least %d characters"; cURL php5 wording updated to "PHP cURL extension"
  • Mage_PaypalUk.csv: "does not exists" → "does not exist"
  • Mage_Customer.csv: "enter you billing/shipping" → "enter your billing/shipping"
  • Mage_Newsletter.csv: "not a valid choices" → "not a valid choice"
  • Mage_Usa.csv: %1-%2%1$s-%2$s sprintf fix; target=_blanktarget="_blank" rel="noopener noreferrer"

Copilot AI requested a review from sreichel April 23, 2026 20:43
@sreichel sreichel added the chore label Apr 23, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

@sreichel sreichel requested a review from Hanmac May 1, 2026 20:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Test Results

1 files  ±    0  1 errors  0 suites   - 3 446   0s ⏱️ -17s
0 tests  - 1 178  0 ✅  - 1 164  0 💤  -    14  0 ❌ ±0 
0 runs   - 4 377  0 ✅  - 1 191  0 💤  - 3 186  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit 8071bce. ± Comparison against base commit ed595d3.

♻️ This comment has been updated with latest results.

@sreichel sreichel marked this pull request as draft May 1, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore translations Relates to app/locale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copilot: cleanup translation.csv

3 participants