phpstan: checks around getConfig + asArray#5601
Open
Hanmac wants to merge 15 commits into
Open
Conversation
github-actions
Bot
added
Component: lib/Varien
sreichel
reviewed
May 22, 2026
sreichel
reviewed
May 22, 2026
sreichel
reviewed
May 22, 2026
sreichel
reviewed
May 22, 2026
sreichel
reviewed
May 22, 2026
Contributor
Author
|
Stupid PHPStrom, lied to me that in |
Contributor
|
`Pls dont add too much. Better smaller PRs. |
Contributor
Author
|
@sreichel yeah, that should be enough for now in Mage_Payment_Helper |
|
Contributor
|
imho ... its already to big ... w/ various changes. DocBlock fixex are worth a small PR ... |
This was referenced May 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Some fixes regarding:
getConfig()which might return null when called as static,getNode()which might return false,asArray()which might return string and not array. (says PHPStan)Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)