fix: graceful db shutdown and correct Docker healthcheck URL#90
Merged
Conversation
- Dispose the async database engine on shutdown to close all pooled aiosqlite connections cleanly, eliminating ResourceWarning on exit. - Fix healthcheck URL in both Dockerfile and docker-compose.yml to use the actual endpoint at /api/v1/health instead of /health (404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the application's health check endpoints and ensures proper cleanup of database connections during shutdown. The changes affect both deployment configuration and backend shutdown logic.
Health check endpoint updates:
Dockerfileanddocker-compose.ymlto use/api/v1/healthinstead of/health, ensuring consistency with the application's API routes. [1] [2]Database connection management:
disposemethod to the database class indatabase.pyto close all pooled connections and dispose of the engine cleanly.main.pyto call the newdisposemethod, ensuring all database connections are properly closed during shutdown.