Skip to content

[feat] IonBuilder #57

Closed
yhteoh wants to merge 12 commits intomainfrom
ion_species
Closed

[feat] IonBuilder #57
yhteoh wants to merge 12 commits intomainfrom
ion_species

Conversation

@yhteoh
Copy link
Copy Markdown
Collaborator

@yhteoh yhteoh commented Mar 25, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    No shortcut for building Ions

  • What is the new behavior (if this is a feature change)?

  • Builders for building commonly used ions
    • Yb171+
    • Ba133+
    • Ba138+
  • Build reduced Ion and allow exclusions
  • Zeeman shift calculations during build
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@yhteoh yhteoh self-assigned this Mar 25, 2025
@yhteoh yhteoh added the enhancement New feature or request label Mar 25, 2025
@yhteoh yhteoh changed the title [feat] IonBuilder abstract class for building ions, and Yb171IIBuilde… [feat] IonBuilder Mar 25, 2025
@yhteoh
Copy link
Copy Markdown
Collaborator Author

yhteoh commented May 27, 2025

This pull request is subsumed in #65 and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant