Skip to content

Atomic: Implementation of IonBuilder and circular polarization support#65

Merged
yhteoh merged 15 commits intomainfrom
atomic
Jun 26, 2025
Merged

Atomic: Implementation of IonBuilder and circular polarization support#65
yhteoh merged 15 commits intomainfrom
atomic

Conversation

@yhteoh
Copy link
Copy Markdown
Collaborator

@yhteoh yhteoh commented May 27, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix and feature

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
  • Support for complex polarization vector
  • Builders for building commonly used ions
    • Yb171+
    • Ba133+
  • Build reduced Ion and allow exclusions
  • Zeeman shift calculations during build
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    This pull request includes the changes from [feat] IonBuilder  #57

@yhteoh yhteoh self-assigned this May 27, 2025
@yhteoh yhteoh added bug Something isn't working enhancement New feature or request labels May 27, 2025
@yhteoh yhteoh mentioned this pull request May 27, 2025
9 tasks
@yhteoh yhteoh linked an issue May 27, 2025 that may be closed by this pull request
@yhteoh yhteoh changed the title Atomic Atomic: Implementation of IonBuilder and circular polarization support Jun 10, 2025
@yhteoh yhteoh requested a review from benjimaclellan June 10, 2025 17:48
@yhteoh yhteoh marked this pull request as ready for review June 10, 2025 17:48
Copy link
Copy Markdown
Member

@benjimaclellan benjimaclellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

"SequentialProtocol",
"AtomicCircuit",
"IonBuilder",
"Yb171IIBuilder",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the II stand for in the builder name?

Copy link
Copy Markdown
Collaborator Author

@yhteoh yhteoh Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A way to note it's an singly ionized ion, the NIST database uses this notation

@yhteoh yhteoh merged commit bbbdd53 into main Jun 26, 2025
15 checks passed
@yhteoh yhteoh deleted the atomic branch June 26, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Complex Input for Wavevector Definition of Beams

2 participants