-
Notifications
You must be signed in to change notification settings - Fork 38
Feature: operations on arrays #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature: operations on arrays #387
Conversation
0a706f5 to
2c46e10
Compare
2c46e10 to
60d0b3e
Compare
|
Tests very much needed |
|
Reminder that NML is not a programming language. What problem does this PR solve? |
|
The checks have caught some errors which are generally self-explanatory. I also wonder what the intended use of this is: large arrays with repetitive values aren't something I've seen in NML sources. |
60d0b3e to
ca95169
Compare
ca95169 to
9455b74
Compare
Acknowledged
Provides ability to recreate feature that You have rejected in #385 in the newgrfs.
It is intended to use this for all lengths of array in order to make code more clean, shorter and easier to maintain. The alternative and currently working solution is to use 3-rd party tools to generate nml code at the compile time, this solution is hard to maintain because it demands knowledge of multiple tools.
Is the 042_for.nml sufficient |
9455b74 to
2d32cab
Compare
Motivation / Problem
As more and more features in NML require users to use arrays it would be reasonable to expand capabilities of array creation.
Description
It allows for creating arrays with following syntax:
[13] * 200or for more complex repetitive arrays:
[13,12,11,15] * 19 * 8and with the "embed for" syntax:
it also adds support for array addition.