-
Notifications
You must be signed in to change notification settings - Fork 12k
fix: improve solhint custom rules and remove TODOs #5497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
The head ref may contain hidden characters: "\u0444\u0444"
Conversation
|
scripts/solhint-custom/index.js
Outdated
|
||
FunctionDefinition(node) { | ||
// Skip constructor, function without a name (receive/fallback) and interface definitions | ||
if (node.isConstructor || node.name == null || node.parent.kind === 'interface') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: prettier rules say that receive and fallback function MUST be external. This creates a conflicts if they are virtual. This leaves us tree options:
- remove virtual from receive/fallback: bit no for me!
- change the prettier config
- (what I did here) skip the rule for receive and fallback functions.
@Amxx what are your thoughts on this PR altogether? I've made some changes to get rid of red failed checks, but they still fail |
This commit improves the solhint custom rules by:
Both TODO comments have been addressed while maintaining the codebase's
coding standards and improving the overall code quality checks.