refactor(app): are you sure you want to cancel modal on desktop app #15662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamarZanzouri
commented
Jul 15, 2024
TamarZanzouri
commented
Jul 15, 2024
TamarZanzouri
commented
Jul 15, 2024
TamarZanzouri
commented
Jul 15, 2024
app/src/organisms/ErrorRecoveryFlows/shared/RecoveryContentWrapper.tsx
Outdated
Show resolved
Hide resolved
TamarZanzouri
commented
Jul 15, 2024
app/src/organisms/ErrorRecoveryFlows/shared/ErrorDetailsModal.tsx
Outdated
Show resolved
Hide resolved
sfoster1
requested changes
Jul 15, 2024
app/src/organisms/ErrorRecoveryFlows/shared/ErrorDetailsModal.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/ErrorRecoveryFlows/shared/ErrorDetailsModal.tsx
Outdated
Show resolved
Hide resolved
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
| @@ -226,7 +226,7 @@ describe('StyledText', () => { | |||
| children: 'h3Bold', | |||
| } | |||
| render(props) | |||
| expect(screen.getByText('h3Bold')).toHaveStyle( | |||
| expect(screen.queryAllByText('h3Bold')[0]).toHaveStyle( | |||
There was a problem hiding this comment.
We generally prefer when rendering only one element for the sake of clarity.
Suggested change
| expect(screen.queryAllByText('h3Bold')[0]).toHaveStyle( | |
| expect(screen.getByText('h3Bold')).toHaveStyle( |
mjhuff
reviewed
Jul 18, 2024
| @@ -243,7 +243,7 @@ describe('StyledText', () => { | |||
| children: 'h4Bold', | |||
| } | |||
| render(props) | |||
| expect(screen.getByText('h4Bold')).toHaveStyle( | |||
| expect(screen.queryAllByText('h4Bold')[0]).toHaveStyle( | |||
There was a problem hiding this comment.
Suggested change
| expect(screen.queryAllByText('h4Bold')[0]).toHaveStyle( | |
| expect(screen.getByText('h4Bold')).toHaveStyle( |
mjhuff
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Are we sure we want to be changing the typography file? We really shouldn't be touching this unless design tells us to, but I could be missing something.
mjhuff
reviewed
Jul 18, 2024
mjhuff
reviewed
Jul 18, 2024
app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/CancelRun.tsx
Outdated
Show resolved
Hide resolved
mjhuff
reviewed
Jul 18, 2024
app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx
Outdated
Show resolved
Hide resolved
mjhuff
reviewed
Jul 18, 2024
app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx
Outdated
Show resolved
Hide resolved
mjhuff
reviewed
Jul 18, 2024
…s.tsx Co-authored-by: Jamey Huffnagle <[email protected]>
Co-authored-by: Jamey Huffnagle <[email protected]>
Co-authored-by: Jamey Huffnagle <[email protected]>
sfoster1
requested changes
Jul 18, 2024
sfoster1
approved these changes
Jul 19, 2024
mjhuff
approved these changes
Jul 19, 2024
TamarZanzouri
deleted the
EXEC-553-desktop-wire-up-are-you-sure-you-want-to-cancel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://opentrons.atlassian.net/browse/EXEC-553.
wire up "are you sure you want to cancel?" desktop ER modal.
Test Plan
Changelog
Mainly change style to support ODD and Desktop apps.
Risk assessment
low.