-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): are you sure you want to cancel modal on desktop app #15662
Merged
TamarZanzouri
merged 43 commits into
edge
from
EXEC-553-desktop-wire-up-are-you-sure-you-want-to-cancel
Jul 19, 2024
Merged
Changes from 17 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
f96860c
initial commit - replace return null
TamarZanzouri 8a25aca
cancel run css styles WIP
TamarZanzouri cead17a
styling desktop
TamarZanzouri b32708e
Merge branch 'edge' into EXEC-553-desktop-wire-up-are-you-sure-you-wa…
TamarZanzouri 8be5efd
adding styles for desktop
TamarZanzouri e4c8e71
refactor
TamarZanzouri 00c5c09
added footer buttons
TamarZanzouri 2a43e0a
reverted ODD changes only and use desktop component
TamarZanzouri 3c595ed
show error details on desktop - not styled yet
TamarZanzouri 07b1ffa
remove isOnDevice flag and fix styling wish media
TamarZanzouri 0298020
fixed missing component
TamarZanzouri 44c8645
manage tips - cancel run WIP
TamarZanzouri d9a7af7
Merge branch 'edge' into EXEC-553-desktop-wire-up-are-you-sure-you-wa…
TamarZanzouri af23b00
merge conflcts
TamarZanzouri e38fdfb
radioButton WIP
TamarZanzouri 4ffac02
styling radio button
TamarZanzouri e3616e7
linting and style fixes
TamarZanzouri 94cd119
Update app/src/organisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx
TamarZanzouri 02d1f21
removed unused component for desktop
TamarZanzouri 59271ed
text style for button
TamarZanzouri 87bb181
removed ErrorDetailsModal for desktop
TamarZanzouri 0238154
pr feedback. moved styling into desktop styles
TamarZanzouri 9a1ecbb
linting and more fixes
TamarZanzouri fe7b6f9
revert radio button changes and apply to radio group
TamarZanzouri 7fb4f11
radio group
TamarZanzouri 2b8eff0
Merge branch 'edge' into EXEC-553-desktop-wire-up-are-you-sure-you-wa…
TamarZanzouri b3df530
manage tips with ER radio group
TamarZanzouri 5cdcaad
do not use isOnDevice for icon rendering
TamarZanzouri 9b92a55
lint and style fixes
TamarZanzouri 6fc1c47
fixed failing tests in manage tips
TamarZanzouri 2b10847
linting
TamarZanzouri d47f4c3
linting and StyledText test fix
TamarZanzouri 71bd2b7
Update app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTip…
TamarZanzouri e7d3c68
Update app/src/atoms/buttons/SmallButton.tsx
TamarZanzouri 7460f00
Update app/src/molecules/InterventionModal/index.tsx
TamarZanzouri bdaa205
pr feedback and removed legacy styled text test
TamarZanzouri 701ff6b
fixed icon styling
TamarZanzouri 8a41e83
css fixes for radio buttons
TamarZanzouri 89fe1ae
reverted changes to LegacyStyledText
TamarZanzouri a4fff54
removed cast
TamarZanzouri 3ba481a
reverted changes to LegacyStyledText
TamarZanzouri 0915b98
fixed linting issue
TamarZanzouri 0fa5ba9
formatting
TamarZanzouri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be a
StyledText
, not aLegacyStyledText
.StyledText
is the one that supportsoddStyle
anddesktopStyle
, whileLegacyStyledText
- which we don't want to use anymore - supportsas