Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-client, app): implement download CSV file #15861

Merged
merged 6 commits into from
Jul 31, 2024
Merged

feat(api-client, app): implement download CSV file #15861

merged 6 commits into from
Jul 31, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jul 31, 2024 •
edited
Loading

blocked by #15848

Overview

Here, I create api-client functions and types for downloading CSV file content from the robot server's dataFiles/{fileId}/download endpoint. I also add a react-api-client wrapper hook and implement in the HistoricalProtocolRunDrawer component.

Test Plan and Hands on Testing

  • Navigate to a historical protocol run for a run that utilized CSV file
  • Expand run drawer
  • Select download and verify that CSV file is downloaded with the correct filename and content

Changelog

  • create api-client function for getCsvFileRaw and types
  • create useCsvFileRawQuery hook
  • implement in HistoricalProtocolRunDrawer

Review requests

see test plan

Risk assessment

low

ncdiehl11 added 4 commits July 31, 2024 11:00
@ncdiehl11
fix(app, api-client): fix response interface for /protocols/{id}/data…
925b0b0 
…Files

There was an error in the client's expected response interface from `/protocols/{id}/dataFiles`,
causing the app to error when expanding `HistoricalProtocolRunDrawer`. This PR fixes that response
interface and the implicated endpoint's implementation in `HistoricalProtocolRunDrawer`.
@ncdiehl11
fix implementation in HistoricalProtocolRun.tsx
677ad5b
@ncdiehl11
stash
84b20f9
@ncdiehl11
Merge branch 'fix_app-recent-run-files' into feat_app-download-csv-file
b2046ae
@ncdiehl11 ncdiehl11 self-assigned this Jul 31, 2024
@ncdiehl11 ncdiehl11 requested review from koji and jerader July 31, 2024 20:57
@ncdiehl11 ncdiehl11 marked this pull request as ready for review July 31, 2024 21:03
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner July 31, 2024 21:03
koji
koji approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the Last Piece!
I left a couple of comments, but the changes make sense to me.

@ncdiehl11 ncdiehl11 mentioned this pull request Jul 31, 2024
Merged
@ncdiehl11 ncdiehl11 merged commit 4497300 into edge Jul 31, 2024
15 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_app-download-csv-file branch July 31, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @koji