-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Addition of Evotip specific commands #17351
Merged
CaseyBatten
merged 27 commits into
chore_release-8.3.0
from
EXEC-907-evotip-specific-commands
Jan 30, 2025
Merged
Changes from 18 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
5b49e05
feat(api): Add the seal command
Laura-Danielle 4ae7f0a
feat(api): Add evotip specific instrument context commands
Laura-Danielle 3a6700e
feat(protocol_engine): Add evotip specific commands to the protocol e…
Laura-Danielle ce55343
api and core hookup for evotip specific commands
CaseyBatten 299bdf3
context cleanup and parameterization
CaseyBatten c456ad7
seal command functionality
CaseyBatten 8912d90
update evotip dispense command
Laura-Danielle 477b1c8
update unseal command with correct parameters
Laura-Danielle 7b06608
fix: handle expected stalls in gantry mover
Laura-Danielle 44b4faf
seal command state update and functionality testing
CaseyBatten ebdfe93
ensure evo tip dispense and unseal functions work
CaseyBatten 4396fa5
papi resin tip command name and doc updates
CaseyBatten 7390be3
default volume and flow rate based on internal evotips testing
CaseyBatten ba1b3ae
fix naming mismatches in core and engine
Laura-Danielle 8447056
fix test mocks missing new parameters
Laura-Danielle 1689445
Merge branch 'chore_release-8.3.0' into EXEC-907-evotip-specific-comm…
CaseyBatten 4e6c7c7
Engine behavior clean up and removal of unnecessary parameters
CaseyBatten 61da984
pickup and drop offset adjustments as well as test fixture correction
CaseyBatten 1577a5c
evotip seal test cleanup and ignore plunger correction
CaseyBatten 117918f
fixing linter errors
Laura-Danielle a131b39
Merge branch 'EXEC-907-evotip-specific-commands' of github.com:Opentr…
Laura-Danielle b1a3619
fix lint and formatting
Laura-Danielle ee624cf
more linter fixes
Laura-Danielle 2288583
fix evotip dispense test and add movement state
Laura-Danielle 9d17f2d
unseal test cleanup removal of unused pushout command and command sch…
CaseyBatten 343ae3c
hardware testing fixes
CaseyBatten 03110bc
clean up docs ref
CaseyBatten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be
Optional
unless it can be none, and if it can be none we should handle theNone
case. looks like justignore_plunger: bool = False
is fine.