fix(app): App support for new lid commands and fix lid error boundary trigger #17386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
approved these changes
Jan 30, 2025
| @@ -287,7 +287,7 @@ export function getFailedCmdRelevantLabware( | |||
| const failedLWURI = runRecord?.data.labware.find( | |||
| labware => labware.id === recentRelevantFailedLabwareCmd?.params.labwareId | |||
| )?.definitionUri | |||
| if (failedLWURI != null) { | |||
| if (failedLWURI != null && Object.keys(lwDefsByURI).includes(failedLWURI)) { | |||
Comment on lines
+45
to
+47
| (commandType === 'loadLabware' || | ||
| commandType === 'loadLid' || | ||
| commandType === 'loadLidStack') && |
There was a problem hiding this comment.
Maybe not in this PR, but could we add a TODO for adding some sort of constant to shared data that contains a list of all possible load commands, and then implement that in the app?
There was a problem hiding this comment.
Yeah, definitely - we won't want to reference all three of these everywhere we search for loadLabware (we'll want to exclude these from LPC, for example) but it would be good to have this as a type
|
Works as expected, I tested it on a flex with both the ODD and Desktop app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix EXEC-1042, RABR-712
Overview
This PR adds the new
loadLidandloadLidStackcommands to the typescript command schema, makes a few necessary utils aware that labware can be loaded through these commands, and adds some null protection where we were hitting an error boundary in the recovery flow due to missing labwareTest Plan and Hands on Testing
On this branch, run a protocol that loads a lid, trigger a stall/collision, and see that you no longer hit an error boundary
I tested this out on desktop and it works as expected! Error recover is now launched and you can address the gripper failure
Changelog
loadLidandloadLidStackcommands to the typescript command schemaReview requests
Look over code changes and test this out if you can
Risk assessment
Low